|
From: <jue...@we...> - 2004-07-17 16:39:50
|
In our current 1.1 codebase, we have an inconsistency regarding the use = of "advice" and "interceptor" in bean property names: AdvisedSupport has = a deprecated "addInterceptor" method now (without hinting at the = preferred method in javadoc, BTW), because of the preferred "addAdvice" = method. =20 While Advice is more general (being a super interface of Interceptor), a = number of other properties use "interceptor" in the name while accepting = Object, for example TransactionProxyFactoryBean's "preInterceptors" and = "postInterceptors", and also ProxyFactoryBean's "interceptorNames". =20 We need to make this consistent. We could either keep the "interceptor" = property names, allowing all kinds of Advices there: This would mean = that AdvisedSupport's "addInterceptor" should not be deprecated. Or we = could use "advice" in all those names: That would mean renaming = (respectively deprecating) quite popular properties. =20 When renaming bean properties, we need to consider that driving those = properties via XML bean definitions will not show any deprecation = warnings, just programmatic usage will. Consequently, many people will = not notice such deprecations, first discovering them when we remove the = deprecated bean properties... =20 Thoughts? Suggestions? =20 Juergen |