Re: [Springframework-developer] Test failures

[<jue...@we...>]

I completely agree: It's best to just move over the code that's actually =
needed for the time being. All that stuff needs proper review before =
getting included in the main codebase. Of course, this is not about =
doubts regarding Keith's code quality: He definitely does a good job =
there! It's just about growing the codebase in a controlled fashion :-)
=20
Juergen
=20

________________________________

Von: spr...@li... im Auftrag =
von Colin Sampaleanu
Gesendet: Do 08.07.2004 23:21
An: spr...@li...
Betreff: Re: [Springframework-developer] Test failures



I moved ClassUtils.java over (along with the related test). I did
comment out 3-4 cases of usage of the Assert class and one ArrayUtils
call in a log.debug call (the latter not really being needed anyways),
as those would have led to bringing in about an additional 12-15 classes
from sandbox. The code in question looks pretty high-quality (looks like
a variation of some utils from commons-lang, along with some new code of
Keith's), but I did not want to bring it over without thinking about it
a bit more; if it's going to get used in other places that's fine, but
it's a lot to move over if it's just going to support those 3-4 Assert
calls...

Colin


Colin Sampaleanu wrote:

> This missing class (ClassUtils) is in the Sandbox. I will move it to
> the main tree.
>
>
> Colin Sampaleanu wrote:
>
>> I actually get build breakage right now due to the JMS changes, even
>> from ant:
>>
>> build:
>>    [mkdir] Created dir: =
D:\src\open\spring-colin\spring\target\classes
>>    [mkdir] Created dir:
>> D:\src\open\spring-colin\spring\target\classes\META-INF
>>
>>    [javac] Compiling 772 source files to
>> D:\src\open\spring-colin\spring\target
>> \classes
>>    [javac]
>> D:\src\open\spring-colin\spring\src\org\springframework\jms\Abstract
>> JmsTemplate.java:63: cannot resolve symbol
>>    [javac] symbol  : class ClassUtils
>>    [javac] location: package util
>>    [javac] import org.springframework.util.ClassUtils;
>>    [javac]                                 ^
>>    [javac]
>> D:\src\open\spring-colin\spring\src\org\springframework\jms\Abstract
>> JmsTemplate.java:701: cannot resolve symbol
>>    [javac] symbol  : variable ClassUtils
>>    [javac] location: class =
org.springframework.jms.AbstractJmsTemplate
>>    [javac]         String shortName =3D ClassUtils.getShortName(
>> orig.getClass().
>> getName() );
>>    [javac]                            ^
>>    [javac] Note: Some input files use or override a deprecated API.
>>    [javac] Note: Recompile with -deprecation for details.
>>    [javac] 2 errors
>>
>>
>> Mark, is it possible you forgot to check in something?
>>
>> Colin
>>
>>
>> Dmitriy Kopylenko wrote:
>>
>>> All tests pass on my machine in Eclipse. I have 3.0 final with jdk
>>> 1.4.2 installed.
>>>
>>> Dmitriy.
>>>
>>> Rod Johnson wrote:
>>>
>>>> I'm getting over 30 failures when running tests in Eclipse. Some =
are
>>>> JDO-related, and may be genuine failures. The others are JNDI
>>>> related and
>>>> look like some static side-effect is sitting around in the
>>>> NamingContextBuilder. (Eclipse keeps the same JVM up.)
>>>>
>>>> R
>>>




-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 -
digital self defense, top technical experts, no vendor pitches,
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer