|
From: Colin S. <col...@ex...> - 2004-07-08 21:17:29
|
I moved ClassUtils.java over (along with the related test). I did comment out 3-4 cases of usage of the Assert class and one ArrayUtils call in a log.debug call (the latter not really being needed anyways), as those would have led to bringing in about an additional 12-15 classes from sandbox. The code in question looks pretty high-quality (looks like a variation of some utils from commons-lang, along with some new code of Keith's), but I did not want to bring it over without thinking about it a bit more; if it's going to get used in other places that's fine, but it's a lot to move over if it's just going to support those 3-4 Assert calls... Colin Colin Sampaleanu wrote: > This missing class (ClassUtils) is in the Sandbox. I will move it to > the main tree. > > > Colin Sampaleanu wrote: > >> I actually get build breakage right now due to the JMS changes, even >> from ant: >> >> build: >> [mkdir] Created dir: D:\src\open\spring-colin\spring\target\classes >> [mkdir] Created dir: >> D:\src\open\spring-colin\spring\target\classes\META-INF >> >> [javac] Compiling 772 source files to >> D:\src\open\spring-colin\spring\target >> \classes >> [javac] >> D:\src\open\spring-colin\spring\src\org\springframework\jms\Abstract >> JmsTemplate.java:63: cannot resolve symbol >> [javac] symbol : class ClassUtils >> [javac] location: package util >> [javac] import org.springframework.util.ClassUtils; >> [javac] ^ >> [javac] >> D:\src\open\spring-colin\spring\src\org\springframework\jms\Abstract >> JmsTemplate.java:701: cannot resolve symbol >> [javac] symbol : variable ClassUtils >> [javac] location: class org.springframework.jms.AbstractJmsTemplate >> [javac] String shortName = ClassUtils.getShortName( >> orig.getClass(). >> getName() ); >> [javac] ^ >> [javac] Note: Some input files use or override a deprecated API. >> [javac] Note: Recompile with -deprecation for details. >> [javac] 2 errors >> >> >> Mark, is it possible you forgot to check in something? >> >> Colin >> >> >> Dmitriy Kopylenko wrote: >> >>> All tests pass on my machine in Eclipse. I have 3.0 final with jdk >>> 1.4.2 installed. >>> >>> Dmitriy. >>> >>> Rod Johnson wrote: >>> >>>> I'm getting over 30 failures when running tests in Eclipse. Some are >>>> JDO-related, and may be genuine failures. The others are JNDI >>>> related and >>>> look like some static side-effect is sitting around in the >>>> NamingContextBuilder. (Eclipse keeps the same JVM up.) >>>> >>>> R >>> |