|
From: Guillaume P. <gpo...@gl...> - 2004-06-18 13:18:45
|
There=27s also the method below that is in the same situation=3A org=2Espringframework=2Eorm=2Ehibernate=2ESessionFactoryUtils=2EcloseSess= ionIfNecessary(Session session=2C SessionFactory sessionFactory) throws C= leanupFailureDataAccessException=3B Guillaume ---- Messages d=B4origine ---- De=3A Thomas Risberg =3Cthomas=2Erisberg=40tridb=2Ecom=3E Date=3A vendredi=2C juin 18=2C 2004 8=3A13 am Objet=3A Re=3A =5BSpringframework-developer=5D Exception from closeConnec= tionIfNecessary =3E I would agree that logging is more appropriate in the finally = =3E clause in = =3E this case=2E =3E = =3E Thomas =3E = =3E j=FCrgen h=F6ller =5Bwerk3AT=5D wrote=3A =3E = =3E =3EThomas=2C Rod=2C everybody=2C =3E =3E = =3E =3EThere is an issue regarding = =3E DataSourceUtils=2EcloseConnectionIfNecessary in our JIRA=3A =3E =3E = =3E =3Ehttp=3A//opensource=2Eatlassian=2Ecom/projects/spring/browse/SPR-1= 72 =3E =3E = =3E =3EThis is indeed undesirable=2E Of course=2C Connection=2Eclose hard= ly = =3E ever throws an exception=2C so it=27s not a big problem=2E We could = =3E still simply log the exception as an error and proceed=2C like we do = =3E in JdbcUtils=2EcloseStatement/closeResultSet=2E =3E =3E = =3E =3EWhat do you think=3F =3E =3E = =3E =3EJuergen =3E =3E =3E =3E =3E =3E------------------------------------------------------- =3E =3EThis SF=2ENet email is sponsored by The 2004 JavaOne(SM) Conferenc= e =3E =3ELearn from the experts at JavaOne(SM)=2C Sun=27s Worldwide Java De= veloper =3E =3EConference=2C June 28 - July 1 at the Moscone Center in San = =3E Francisco=2C CA =3E =3EREGISTER AND SAVE! http=3A//java=2Esun=2Ecom/javaone/sf Priority C= ode = =3E NWMGYKND=3E=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F= =5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F= =5F=5F =3E =3ESpringframework-developer mailing list =3E =3ESpringframework-developer=40lists=2Esourceforge=2Enet =3E =3Ehttps=3A//lists=2Esourceforge=2Enet/lists/listinfo/springframework= - =3E developer=3E =3E =3E =3E =3E =3E =3E = =3E =3E =3E = =3E = =3E = =3E ------------------------------------------------------- =3E This SF=2ENet email is sponsored by The 2004 JavaOne(SM) Conference =3E Learn from the experts at JavaOne(SM)=2C Sun=27s Worldwide Java Devel= oper =3E Conference=2C June 28 - July 1 at the Moscone Center in San = =3E Francisco=2C CA =3E REGISTER AND SAVE! http=3A//java=2Esun=2Ecom/javaone/sf Priority Code= = =3E NWMGYKND=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F= =5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F= =5F =3E Springframework-developer mailing list =3E Springframework-developer=40lists=2Esourceforge=2Enet =3E https=3A//lists=2Esourceforge=2Enet/lists/listinfo/springframework-de= veloper =3E |