Re: [Springframework-developer] BeanWrapperImpl abstraction

[<jue...@we...>]

Alef,

I wouldn't mind such a refactoring. However, I don't see the clear =
distinction between the new base class and BeanWrapperImpl: If the base =
class contains everything including bean introspection, what exactly is =
BeanWrapperImpl supposed to add - respectively, what does your own =
subclass do differently?

I assume that your own subclass wouldn't implement the BeanWrapper =
interface in the first place, because it has its own API way. I just =
wonder what it looks like then :-)

I doubt that there will ever be an alternative implementation of the =
BeanWrapper interface itself. It still makes sense to decouple interface =
and implementation here, if just for testability. BeanWrapperImpl =
already is a quite complex piece that you shouldn't necessarily work =
with directly.

In particular, BeanWrapperImpl has some public methods that are *not* in =
the BeanWrapper interface, for advanced functionality that is not =
typically needed in application code.

If the changes don't affect the public BeanWrapper API, I wouldn't mind =
including them in 1.0.3 - provided that we're just talking about a =
refactoring that does not modify existing functionality.

Juergen


-----Original Message-----
From: spr...@li...
[mailto:spr...@li...]On Behalf
Of Rod Johnson
Sent: Tuesday, June 08, 2004 10:37 AM
To: spr...@li...
Subject: Re: [Springframework-developer] BeanWrapperImpl abstraction


Alef

>Would it be an idea to do a small refactoring of the BeanWrapper (for
1.1 or 1.2) and to create the following:

AbstractBeanWrapper:
- customer editors
- introspection stuff
- convenience methods (getPropertyNameTokens and some of the other ones)

BeanWrapperImpl:
- backed by an object and doing the actual setting and getting of
properties

>Yes yes, I know, extending the BeanWrapper is a rare use case, but by
doing it I don't have to change a thing to my web layer ;-)

I'm in favour of this refactoring. After all, the BeanWrapper interface =
only
makes sense if BeanWrapperImpl isn't the only possible impl.

Rgds
Rod




-------------------------------------------------------
This SF.Net email is sponsored by: GNOME Foundation
Hackers Unite!  GUADEC: The world's #1 Open Source Desktop Event.
GNOME Users and Developers European Conference, 28-30th June in Norway
http://2004/guadec.org
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer