Menu
▾
▴
Re: [Springframework-developer] Preparing for 1.0.2
|
From: <tho...@tr...> - 2004-05-27 17:53:00
|
I like consistency across different packages in the framework. +1 for DataSource as key :-) Thomas Quoting "jürgen höller [werk3AT]" <jue...@we...>: > Looking at it the other way round: Why not use the DataSource itself as = > key? That's what we're doing to manage transactional resources too. > > Juergen > > > -----Original Message----- > From: spr...@li... > [mailto:spr...@li...]On Behalf > Of tho...@tr... > Sent: Thursday, May 27, 2004 5:38 PM > To: spr...@li... > Subject: Re: [Springframework-developer] Preparing for 1.0.2 > > > > I remember we considered it extremely unlikely that two datasources for > different database products would have the same hash value - also, the = > worst > case scenario would be a poor translation of an error. It would not = > cause an > error. > > If you feel using the actual datasource as the key is safer, then I'm OK = > with > that too. > > Thomas > > > Quoting "j=FCrgen h=F6ller [werk3AT]" <jue...@we...>: > > > I've also reworked SQLErrorCodesFactory to use the DataSource itself = > as =3D > > key of the dataSourceProductName HashMap, instead of the previous =3D > > Integer built from DataSource.hashCode. With the new SQLErrorCodes =3D > > themselves being held in a WeakReference, this shouldn't cause garbage = > =3D > > collection issues. > > > > Actually, the previous strategy wasn't entirely safe: If two different = > =3D > > DataSources had the same hashCode, they would have overwritten each = > =3D > > other in the Map, as the corresponding Integer keys would have been = > =3D > > equal. With the DataSources themselves as keys, same hashCodes would = > =3D > > just result in less efficient hash lookup but correct storage of both = > =3D > > DataSources. > > > > Juergen > > > > > > -----Original Message----- > > From: spr...@li... > > [mailto:spr...@li...]On = > Behalf > > Of j=3DFCrgen h=3DF6ller [werk3AT] > > Sent: Thursday, May 27, 2004 11:08 AM > > To: spr...@li... > > Subject: Re: [Springframework-developer] Preparing for 1.0.2 > > > > > > Further minor refinements that I committed yesterday: > > =3D20 > > - added IncorrectResultSizeDataAccessException to dao package > > - added DataAccessUtils class to dao.support package, providing =3D > > "uniqueResult" and "requiredUniqueResult" methods > > - refactored SqlQuery.findObject to delegate to =3D > > DataAccessUtils.uniqueResult > > =3D20 > > DataAccessUtils.uniqueResult should be useful for any DAO that = > receives =3D > > a List and expects a unique result object in it, for example with =3D > > Hibernate finders, i.e. Session.find respectively =3D > > HibernateTemplate.find. The uniqueResult method throws =3D > > IncorrectResultSizeDataAccessException if the result is not actually = > =3D > > unique; that's why it is in the dao.support package. > > =3D20 > > Juergen > > =3D20 > > > > ________________________________ > > > > Von: spr...@li... im Auftrag = > =3D > > von j=3DFCrgen h=3DF6ller [werk3AT] > > Gesendet: Do 27.05.2004 10:33 > > An: spr...@li... > > Betreff: Re: [Springframework-developer] Preparing for 1.0.2 > > > > > > > > Oh well, time schedules and my perfectionism... > > > > I've done some further polishing, committed yesterday morning =3D > > respectively today: > > > > - I've factored out RowMapperResultReader from SqlParameter, to make = > =3D > > RowMapper usable for plain JDBC queries too > > - JdbcTemplate.call respectively StoredProcedure supports =3D > > ResultSetExtractor as output parameter too > > - I've slightly refactored JdbcTemplate.call's implementation to allow = > =3D > > for a higher level of code reuse > > > > - AbstractAutowireCapableBeanFactory catches Throwable on bean = > creation, =3D > > rethrowing it as meaningful BeanCreationException > > - DefaultListableBeanFactory.preInstantiateSingletons cleans up = > already =3D > > created singletons if it fails > > - XmlViewResolver and ResourceBundleViewResolver clean up their view = > =3D > > bean factories on context shutdown > > > > Thomas, it would be great if you had a chance to review the JDBC =3D > > changes, and maybe run a couple of integration tests with stored =3D > > procedures - to make sure that I haven't broken anything, even if the = > =3D > > test suite passes. > > > > As there haven't been any reports on problems with the garbage =3D > > collection changes, I plan to go ahead and finalize 1.0.2 for = > tomorrow. > > > > Juergen > > > > > > ________________________________ > > > > Von: spr...@li... im Auftrag = > =3D > > von j=3DFCrgen h=3DF6ller [werk3AT] > > Gesendet: Mi 26.05.2004 07:38 > > An: spr...@li... > > Betreff: Re: [Springframework-developer] Preparing for 1.0.2 > > > > > > > > There hasn't been any change in AbstractXsltView since 1.0 final, so I = > =3D > > guess this is usual behavior... > > > > BTW, current planned release date: tonight! I know, I know - this time = > =3D > > for real, provided that there's no showstopper :-) > > > > Juergen > > > > > > ________________________________ > > > > Von: spr...@li... im Auftrag = > =3D > > von Darren Davison > > Gesendet: Mi 26.05.2004 01:40 > > An: spr...@li... > > Betreff: Re: [Springframework-developer] Preparing for 1.0.2 > > > > > > > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > On Wednesday 26 May 2004 00:27, Darren Davison wrote: > > > > > AbstractXsltView (line 143) shown below is throwing a > > > TransformerConfigurationException. The stylesheet is correctly = > loaded > > > and appears valid whether loaded from a servlet context resource or = > a > > > classpath resource (the 2 I tried). > > > > hmm.. > > > > it seems that removing any <xsl:output> tags in the stylesheets =3D > > themselves > > makes the problem disappear. That strikes me as a bit odd though: has > > something changed recently in XSL world? I can't find any info on =3D > > this.. > > > > Cheers, > > - -- > > Darren Davison > > Public Key: http://www.davison.uk.net/pages/key.htm > > -----BEGIN PGP SIGNATURE----- > > Version: GnuPG v1.2.4 (GNU/Linux) > > > > iD8DBQFAs9l7KLMLAN01aw0RAgFCAJ97NbqA547fyx6rCQLiSXkCUFWreQCghOiD > > Tle6ycCFcmn5hNf2ZLZznX0=3D3D > > =3D3D4YWT > > -----END PGP SIGNATURE----- > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by: Oracle 10g > > Get certified on the hottest thing ever to hit the market... Oracle = > 10g. > > Take an Oracle 10g class now, and we'll give you the exam FREE. > > http://ads.osdn.com/?ad_id149&alloc_id=3D8166&op=3D3Dick > > _______________________________________________ > > Springframework-developer mailing list > > Spr...@li... > > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by: Oracle 10g > > Get certified on the hottest thing ever to hit the market... Oracle = > 10g. > > Take an Oracle 10g class now, and we'll give you the exam FREE. > > http://ads.osdn.com/?ad_id149&alloc_id=3D8166&op=3D3Dick > > _______________________________________________ > > Springframework-developer mailing list > > Spr...@li... > > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by: Oracle 10g > > Get certified on the hottest thing ever to hit the market... Oracle = > 10g. > > Take an Oracle 10g class now, and we'll give you the exam FREE. > > http://ads.osdn.com/?ad_id149&alloc_id=3D8166&op=3D3Dick > > _______________________________________________ > > Springframework-developer mailing list > > Spr...@li... > > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by: Oracle 10g > > Get certified on the hottest thing ever to hit the market... Oracle = > 10g. =3D > > > > Take an Oracle 10g class now, and we'll give you the exam FREE. > > http://ads.osdn.com/?ad_id149&alloc_id=3D8166&op=3D3Dick > > _______________________________________________ > > Springframework-developer mailing list > > Spr...@li... > > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by: Oracle 10g > > Get certified on the hottest thing ever to hit the market... Oracle = > 10g. > > Take an Oracle 10g class now, and we'll give you the exam FREE. > > http://ads.osdn.com/?ad_id=3D3149&alloc_id=3D8166&op=3Dclick > > _______________________________________________ > > Springframework-developer mailing list > > Spr...@li... > > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: Oracle 10g > Get certified on the hottest thing ever to hit the market... Oracle 10g. = > > Take an Oracle 10g class now, and we'll give you the exam FREE. > http://ads.osdn.com/?ad_id=3D3149&alloc_id=3D8166&op=3Dclick > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > ------------------------------------------------------- > This SF.Net email is sponsored by: Oracle 10g > Get certified on the hottest thing ever to hit the market... Oracle 10g. > Take an Oracle 10g class now, and we'll give you the exam FREE. > http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > |
