|
From: <tho...@tr...> - 2004-05-27 15:38:09
|
I remember we considered it extremely unlikely that two datasources for different database products would have the same hash value - also, the worst case scenario would be a poor translation of an error. It would not cause an error. If you feel using the actual datasource as the key is safer, then I'm OK with that too. Thomas Quoting "jürgen höller [werk3AT]" <jue...@we...>: > I've also reworked SQLErrorCodesFactory to use the DataSource itself as = > key of the dataSourceProductName HashMap, instead of the previous = > Integer built from DataSource.hashCode. With the new SQLErrorCodes = > themselves being held in a WeakReference, this shouldn't cause garbage = > collection issues. > > Actually, the previous strategy wasn't entirely safe: If two different = > DataSources had the same hashCode, they would have overwritten each = > other in the Map, as the corresponding Integer keys would have been = > equal. With the DataSources themselves as keys, same hashCodes would = > just result in less efficient hash lookup but correct storage of both = > DataSources. > > Juergen > > > -----Original Message----- > From: spr...@li... > [mailto:spr...@li...]On Behalf > Of j=FCrgen h=F6ller [werk3AT] > Sent: Thursday, May 27, 2004 11:08 AM > To: spr...@li... > Subject: Re: [Springframework-developer] Preparing for 1.0.2 > > > Further minor refinements that I committed yesterday: > =20 > - added IncorrectResultSizeDataAccessException to dao package > - added DataAccessUtils class to dao.support package, providing = > "uniqueResult" and "requiredUniqueResult" methods > - refactored SqlQuery.findObject to delegate to = > DataAccessUtils.uniqueResult > =20 > DataAccessUtils.uniqueResult should be useful for any DAO that receives = > a List and expects a unique result object in it, for example with = > Hibernate finders, i.e. Session.find respectively = > HibernateTemplate.find. The uniqueResult method throws = > IncorrectResultSizeDataAccessException if the result is not actually = > unique; that's why it is in the dao.support package. > =20 > Juergen > =20 > > ________________________________ > > Von: spr...@li... im Auftrag = > von j=FCrgen h=F6ller [werk3AT] > Gesendet: Do 27.05.2004 10:33 > An: spr...@li... > Betreff: Re: [Springframework-developer] Preparing for 1.0.2 > > > > Oh well, time schedules and my perfectionism... > > I've done some further polishing, committed yesterday morning = > respectively today: > > - I've factored out RowMapperResultReader from SqlParameter, to make = > RowMapper usable for plain JDBC queries too > - JdbcTemplate.call respectively StoredProcedure supports = > ResultSetExtractor as output parameter too > - I've slightly refactored JdbcTemplate.call's implementation to allow = > for a higher level of code reuse > > - AbstractAutowireCapableBeanFactory catches Throwable on bean creation, = > rethrowing it as meaningful BeanCreationException > - DefaultListableBeanFactory.preInstantiateSingletons cleans up already = > created singletons if it fails > - XmlViewResolver and ResourceBundleViewResolver clean up their view = > bean factories on context shutdown > > Thomas, it would be great if you had a chance to review the JDBC = > changes, and maybe run a couple of integration tests with stored = > procedures - to make sure that I haven't broken anything, even if the = > test suite passes. > > As there haven't been any reports on problems with the garbage = > collection changes, I plan to go ahead and finalize 1.0.2 for tomorrow. > > Juergen > > > ________________________________ > > Von: spr...@li... im Auftrag = > von j=FCrgen h=F6ller [werk3AT] > Gesendet: Mi 26.05.2004 07:38 > An: spr...@li... > Betreff: Re: [Springframework-developer] Preparing for 1.0.2 > > > > There hasn't been any change in AbstractXsltView since 1.0 final, so I = > guess this is usual behavior... > > BTW, current planned release date: tonight! I know, I know - this time = > for real, provided that there's no showstopper :-) > > Juergen > > > ________________________________ > > Von: spr...@li... im Auftrag = > von Darren Davison > Gesendet: Mi 26.05.2004 01:40 > An: spr...@li... > Betreff: Re: [Springframework-developer] Preparing for 1.0.2 > > > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Wednesday 26 May 2004 00:27, Darren Davison wrote: > > > AbstractXsltView (line 143) shown below is throwing a > > TransformerConfigurationException. The stylesheet is correctly loaded > > and appears valid whether loaded from a servlet context resource or a > > classpath resource (the 2 I tried). > > hmm.. > > it seems that removing any <xsl:output> tags in the stylesheets = > themselves > makes the problem disappear. That strikes me as a bit odd though: has > something changed recently in XSL world? I can't find any info on = > this.. > > Cheers, > - -- > Darren Davison > Public Key: http://www.davison.uk.net/pages/key.htm > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.2.4 (GNU/Linux) > > iD8DBQFAs9l7KLMLAN01aw0RAgFCAJ97NbqA547fyx6rCQLiSXkCUFWreQCghOiD > Tle6ycCFcmn5hNf2ZLZznX0=3D > =3D4YWT > -----END PGP SIGNATURE----- > > > ------------------------------------------------------- > This SF.Net email is sponsored by: Oracle 10g > Get certified on the hottest thing ever to hit the market... Oracle 10g. > Take an Oracle 10g class now, and we'll give you the exam FREE. > http://ads.osdn.com/?ad_id149&alloc_id=8166&op=3Dick > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: Oracle 10g > Get certified on the hottest thing ever to hit the market... Oracle 10g. > Take an Oracle 10g class now, and we'll give you the exam FREE. > http://ads.osdn.com/?ad_id149&alloc_id=8166&op=3Dick > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: Oracle 10g > Get certified on the hottest thing ever to hit the market... Oracle 10g. > Take an Oracle 10g class now, and we'll give you the exam FREE. > http://ads.osdn.com/?ad_id149&alloc_id=8166&op=3Dick > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: Oracle 10g > Get certified on the hottest thing ever to hit the market... Oracle 10g. = > > Take an Oracle 10g class now, and we'll give you the exam FREE. > http://ads.osdn.com/?ad_id149&alloc_id=8166&op=3Dick > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > ------------------------------------------------------- > This SF.Net email is sponsored by: Oracle 10g > Get certified on the hottest thing ever to hit the market... Oracle 10g. > Take an Oracle 10g class now, and we'll give you the exam FREE. > http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > |