[Springframework-developer] confusion in jpetstore sample

[Hunter K. <re...@ei...>]

Hi there, I'm plowing through the wonderful world of SOAP, Jax-RPC, Axis, etc.

I was looking at the sample server-deploy.wsdd in 
samples/jpetstore/war/WEB-INF/server-config.wsdd, and come across the 
following:

 <service name="OrderService" provider="java:RPC">
  <parameter name="allowedMethods" value="*"/>
  <parameter name="className" 
value="org.springframework.samples.jpetstore.service.server.JaxRpcOrde
rService"/>
        <beanMapping qname="jpetstore:Order" xmlns:jpetstore="urn:BeanService" 
languageSpecificType=
"java:org.springframework.samples.jpetstore.domain.Order"/>
        <beanMapping qname="jpetstore:LineItem" 
xmlns:jpetstore="urn:BeanService" languageSpecificTy
pe="java:org.springframework.samples.jpetstore.domain.LineItem"/>
        <beanMapping qname="jpetstore:Item" xmlns:jpetstore="urn:BeanService" 
languageSpecificType="
java:org.springframework.samples.jpetstore.domain.Item"/>
        <beanMapping qname="jpetstore:Product" 
xmlns:jpetstore="urn:BeanService" languageSpecificTyp
e="java:org.springframework.samples.jpetstore.domain.Product"/>
 </service>


Now the problem I have is with the beanMappings.  My problem is the attribute
xmlns:jpetstore="urn:BeanService" and I kept wondering what the 
"urn:BeanService" was referring to, until I realized that is from one of the 
examples in the Axis distribution.

I think it would be much clearer if the beanMappings looked like:

<beanMapping qname="jpetstore:LineItem" xmlns:jpetstore="urn:JPetStore" .../>

I think that would make it easier for people coming into it (like me) to 
realize that the "urn:JPetStore" was just a local constant, instead of some
kind of deep magic - "urn:BeanService" is needlessly confusing.

I can make the changes myself and send in a patch if people are interested, 
but I figured that it's such a small change a comitter might find it easier 
to do themselves...

H