Re: [Springframework-developer] JdbcUtils.extractDatabaseMetaData

[<tho...@tr...>]

Juergen,

That's a good change - I don't really like names that are too long.  I just
based the name on RowCallbackHandler.  Since we have other XxxCallback
interfaces this new name is better.

Thomas

Quoting "jürgen höller [werk3AT]" <jue...@we...>:

> Thomas,
> =20
> In a last minute change before the 1.0.1 release, I've renamed =
> DatabaseMetaDataCallbackHandler to DatabaseMetaDataCallback, in analogy =
> to PreparedStatementCallback/HibernateCallback/JdoCallback etc. In =
> particular for names that are long enough already, I suggest to stick to =
> *Callback for consistency. I hope you don't mind the change; I didn't =
> want to delay the release any longer.
> =20
> Juergen
> =20
> 
> ________________________________
> 
> Von: spr...@li... im Auftrag =
> von Thomas Risberg
> Gesendet: Mi 21.04.2004 03:19
> An: spr...@li...
> Betreff: Re: [Springframework-developer] =
> JdbcUtils.extractDatabaseMetaData
> 
> 
> 
> 
> >
> >The javadoc of JdbcUtils.extractDatabaseMetaData says that the method =
> will never throw an exception, but it still throws a =
> MetaDataAccessException on any kind of failure. Shouldn't it simply log =
> exceptions and return null?
> >=20
> >
> That must have been an old comment that I forgot to change.  I have
> modified it to reflect that this method does throw a checked exception
> since we can't rely on the exception translation to be initialized when
> this method is called.  This method is infrequently used and I'd rather
> force the use of a catch block instead of relying on calling code to
> check for a null returned.
> 
> >
> >Furthermore, why is the DatabaseMetaDataCallbackHandler interface in =
> the jdbc.core package? It is just used in the jdbc.support package, =
> which shouldn't depend on jdbc.core (just the other way round). =
> Consequently, I suggest to move it to jdbc.support.
> >
> >=20
> >
> Good point.  I have moved it.
> 
> Thomas
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: IBM Linux Tutorials
> Free Linux tutorial presented by Daniel Robbins, President and CEO of
> GenToo technologies. Learn everything from fundamentals to system
> administration.http://ads.osdn.com/?ad_id=3D1470&alloc_id=3D3638&op=3Dcli=
> ck
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
> 
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: IBM Linux Tutorials
> Free Linux tutorial presented by Daniel Robbins, President and CEO of
> GenToo technologies. Learn everything from fundamentals to system
> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>