Re: [Springframework-developer] Preparing for 1.0.1

[Colin S. <col...@ex...>]

+1

jürgen höller [werk3AT] wrote:

>A minor naming issue that I've noticed: We have an AbstractPrototypeTargetSource, which serves as base class for PrototypeTargetSource, ThreadLocalTargetSource and AbstractPoolingTargetSource. We don't have the AbstractXxx/Xxx naming pattern anywhere else in the framework. (I've actually removed a similar naming pattern in the AbstractAutoProxyCreator area before 1.0 final.)
> 
>Furthermore, "AbstractPrototypeTargetSource" is actually a bit misleading, as we're using a broader meaning of the word prototype here than found in bean definitions. "PrototypeTargetSource" matches the bean definition term exactly, but the base class is more generic: So what about renaming it to "AbstractDynamicTargetSource" or the like, indicating that it serves as base class for all non-singleton TargetSources?
> 
>Like the AopUtils move, this should be fine in terms of compatibility level, as the base class is not part of the public API but rather an internal implementation detail. PrototypeTargetSource and co will still be fully backward compatible after that change, and I doubt that anyone has implemented custom TargetSources yet (and even if, it's trivial to adapt).
> 
>Juergen
> 
>
>________________________________
>
>Von: spr...@li... im Auftrag von Rod Johnson
>Gesendet: Fr 02.04.2004 16:53
>An: spr...@li...
>Betreff: Re: [Springframework-developer] Preparing for 1.0.1
>
>
>
>I suggest that we sit on this code for at least a week until we release it,
>so we can catch anything else. How about we target Monday week for release?
>
>A 1.0.1 release should be driven by stability, not date, so we should see if
>any more issues come out of the woodwork.
>
>----- Original Message -----
>From: "jürgen höller [werk3AT]" <jue...@we...>
>To: <spr...@li...>
>Sent: Friday, April 02, 2004 10:57 AM
>Subject: [Springframework-developer] Preparing for 1.0.1
>
>
>Hi everybody,
>
>From my point of view, the code is ready for release 1.0.1. There were a
>couple of bug fixes and minor enhancements since 1.0 final. The most
>important fix is proper Hibernate/JTA resource management when flush fails.
>Enhancements include the introduction of the MessageCodesResolver interface
>in the validation package, and a more efficient internal implementation of
>AbstractMessageSource. See the changelog for details.
>
>Please give the current CVS snapshot a try. There shouldn't be any issues,
>as changes are minor and just affect specific functionality. I'd like to
>target mid next week for the release, i.e. two weeks after 1.0 final. In the
>meantime, the only thing I plan to address is the lack of remoting coverage
>in the reference docs. If anyone feels the need to improve other parts of
>the docs, please do so till mid next week!
>
>Juergen
>  
>