[Springframework-developer] VelocityEngineFactory

[Darren D. <da...@da...>]

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


VelocityEngineFactory.initVelocityEngine is a public unsynchronized method.=
 =20
It's scope was widened in 1.0-m3.  It seems to have been made public so=20
that VelocityConfigurer can call it. =20

If it's ok to leave it public and unsynchronized,then it looks odd that the=
=20
VelocityEngineFactory.getVelocityEngine() method is synchronized.  It=20
returns the initialized VelocityEngine instance or calls=20
initVelocityEngine() before returning the instance.

Should VelocityConfigurer call VelocityEngineFactory.getVelocityEngine()=20
instead so that initVelocityEngine() can be protected?  Or am I missing=20
something else (as usual)?

=2D --=20

Darren Davison
Public Key: http://www.davison.uk.net/key.jsp
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAQze1KLMLAN01aw0RAlQRAJ4vY6cTubGcpHUXFXmmqUQNr5q7fQCgnWgM
wwz8DGKkMulwA90hH6ZtpvI=3D
=3DV4Ys
=2D----END PGP SIGNATURE-----