|
From: Rod J. <rod...@in...> - 2004-02-28 21:45:08
|
>Good point - changed to IllegalArgumentException. >I just didn't want to throw CannotGetJdbcConnectionException like before; it arguably wasn't appropriate. In general. the DataSource implementations shouldn't use DataAccessExceptions in the first place. I disagree. I think that the user should be able to catch DataAccessException confidently in all cases (which was why I changed from ClassNotFoundException to a DataAccessException). I don't have terribly strong views on this as it's not a production usage class anyway--but that also implies it wasn't really worth changing the behaviour either... |