From: Francois B. <fra...@gm...> - 2009-03-22 12:19:03
|
I see many tests failing to compile against Boost svn HEAD with this kind of errors: .../support/detail/sign.hpp:56: error: no type named 'bits' in 'struct boost::math::detail::fp_traits_native<float>' .../support/detail/sign.hpp:57: error: 'get_bits' is not a member of 'boost::math::detail::fp_traits_native<float>' coming from boost::spirit::detail::changesign. This looks related to the use of a custom version of boost::math::signbit depending on the Boost version. I didn't follow closely the original problem and the history of changes, so I thought I should ask before committing random stuff in that area :) The attached patch makes those tests pass again with both Boost 1.38 and svn HEAD. It: - fixes another error when building with Boost <1.39 (missing include of Boost.Math fpclassify.hpp), - fixes the errors above when building with Boost svn HEAD by moving the include of fp_traits.hpp out of the condition on Boost version, since boost::spirit::detail::changesign always needs it (as there is no boost::math::changesign, even in Boost svn HEAD). Does this look OK to you? By the way, is it useful to keep support/detail/math/fpclassify.hpp and signbit.hpp, I don't see where they are used? (presumably Johan Rade's whole FP traits library was copied, but only fp_traits.hpp is actually used?) Thanks, François |