Re: [SoX-devel] SoX 14.1.0 Release Candidate 1

[Dave Y. <dav...@te...>]

On 06/30/08 01:52 pm, Chris Bagwell wrote:
> On Sun, Jun 29, 2008 at 07:33:09PM -0700, Dave Yeo wrote:
>> On 06/29/08 05:43 pm, Chris Bagwell wrote:
>>> Hello all,
>>>
>>> There is a new release candidate for SoX 14.1.0.  I am experimenting
>>> with using Sourceforges normal file manager for this cycle.  Please give
>>> this a try on as many platforms as you have access to.
>>>
>> Hi Chris, I had to include unistd.h in src/sox.h to pickup off_t.
>
> Thanks for the reports!  I'm submitting updates to CVS right now.
>
> I'm adding unistd.h to sox_i.h for off_t specifically.  I don't
> see references to off_t in sox.h.
>

Here's the error
gcc.exe -DHAVE_CONFIG_H -I.  -DLADSPA_PATH="\"/usr/local/lib/ladspa\"" 
-DPKGLIBDIR="\"/usr/local/lib/sox\""  -Wconversion  -g -O2 
-D_FORTIFY_SOURCE=2 -Wall -W -Wmissing-prototypes -Wstrict-prototypes 
-pedantic -MT sox.o -MD -MP -MF .deps/sox.Tpo -c -o sox.o sox.c
In file included from sox.c:26:
sox.h:360: error: parse error before "off_t"
sox.h:360: warning: no semicolon at end of struct or union
...

Error also happens if unistd.h is only included in sox_i.h

>> Also had to change src/gsm.c and src/wav.c
>>
>> #ifdef EXTERNAL_GSM
>> -#include<gsm/gsm.h>
>> +#include<gsm.h>
>> #else
>> #include "../libgsm/gsm.h"
>> #endif
>>
>
> Opps, we were checking for both gsm.h and gsm/gsm.h in configure
> but ignoring the results.
>

More info, upon testing I realized that sox had no audio file formats. 
Fix was to disable libltdl as libtool did not want to create DLLs and 
they probably would not have loaded anyways. The OS/2 kernel DLL loader 
is restricted to 8.3 names.
Perhaps should add *os2* below Cygwin in the Force off using libltdl 
section of configure.ac. Sorry for not making a patch but short of time 
and my autoconf does not want to make a working configure script.
Dave