Re: [Soprano-devel] Review Request: Remove Windows specific code from sopranoclient by using the KDEWin compatibility library

[Sebastian T. <seb...@tr...>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104872/#review13534
-----------------------------------------------------------

Ship it!


I had so hoped that someone would do this! Thank you! I had no idea how to do that on Windows. Of course had I known it would be this simple...
Would it be hard to drop the kdewin dependency, maybe by simply including a copy of the interesting parts?

- Sebastian Trueg


On May 6, 2012, 4:45 p.m., Andre Heinecke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104872/
> -----------------------------------------------------------
> 
> (Updated May 6, 2012, 4:45 p.m.)
> 
> 
> Review request for Soprano, Patrick Spendrin and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> The new implementation of the client socket connection did not compile for Windows.
> Instead of fixing it by adding even more ifdefs I used the socket / un headers from KDE-Windows to make the Unix code compile on Windows.
> As they don't do much except adding some defines and including winsock, this should be quite safe.
> 
> The added charm (except using the new and simpler implementation also on windows) is that there is no longer any Q_OS_WIN ifdef in soprano/client
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d42397a 
>   client/CMakeLists.txt c1fa916 
>   client/clientconnection.cpp 3565f4d 
>   client/clientconnection_p.h 003472f 
>   client/localsocketclient.h a31c694 
>   client/localsocketclient.cpp cea06bc 
>   client/socket.h 5cdc00b 
>   client/socketstream.cpp dfd8713 
>   cmake/modules/FindKDEWin.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104872/diff/
> 
> 
> Testing
> -------
> 
> Compiled on Windows and Linux and ran localsocketmultithreadtest
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>