SMPlayer / Patches / #32 Make smplayer.desktop compliant with f.d.o spec

#32 Make smplayer.desktop compliant with f.d.o spec

Status: closed

Owner: Ricardo Villalba

Labels: None

Priority: 5

Updated: 2009-10-04

Created: 2009-05-23

Creator: Sterling X. Winter

Private: No

This patch makes the following changes to smplayer.desktop to bring it in line with the freedesktop.org Desktop Entry Specification [1]:

* Change value of GenericName key to "Media Player", with translations borrowed from kaffeine.desktop and kmplayer.desktop. Translations were double-checked against Google Translations and seem to be at least literally correct, but they should probably be verified by native speakers also.

* Terminate list value for MimeType key with a semicolon.

[1] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html

Discussion

Sterling X. Winter - 2009-05-23

Fix smplayer.desktop file

desktop-file-genericname.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ricardo Villalba - 2009-06-09

assigned_to: nobody --> rvm
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Sterling X. Winter - 2009-09-28

I see that GenericName is now being used correctly in smplayer.desktop in svn trunk, but the MimeType issue mentioned above still hasn't been fixed and still fails the freedesktop.org test:

$ desktop-file-validate smplayer.desktop
smplayer.desktop: error: value "audio/ac3;audio/mp4;audio/mpeg;audio/vnd.rn-realaudio;audio/vorbis;audio/x-adpcm;audio/x-matroska;audio/x-mp2;audio/x-mp3;audio/x-ms-wma;audio/x-vorbis;audio/x-wav;audio/mpegurl;audio/x-mpegurl;audio/x-pn-realaudio;audio/x-scpls;video/avi;video/mp4;video/flv;video/mpeg;video/quicktime;video/vnd.rn-realvideo;video/x-matroska;video/x-ms-asf;video/x-msvideo;video/x-ms-wmv;video/x-ogm;video/x-theora" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character

Please fix this so we won't have to keep patching it downstream. Thanks.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Sterling X. Winter - 2009-10-01

The commit message for r3220 references a Launchpad bug [1] as the reasoning for the GenericName fix. That bug was filed Aug. 5 and fixed the same day, but I submitted this patch to fix the very same problem more than two months earlier and it now seems to have been ignored. Is it a waste of time to submit patches here? Should I file bugs instead from now on?

[1] https://bugs.launchpad.net/ubuntu/+source/smplayer/+bug/409403

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ricardo Villalba - 2009-10-01

I review the patches when I have time. Sorry for the delay.

Bug reports indeed have priority.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Sterling X. Winter - 2009-10-04

Closing then. Filed as bug ID 2872587.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Sterling X. Winter - 2009-10-04

status: open --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.