do_smooth_draw_shadow isn't crashproof

Status: Alpha

Brought to you by: aj_genius

#4 do_smooth_draw_shadow isn't crashproof

Status: open

Owner: nobody

Labels: None

Priority: 5

Updated: 2010-08-28

Created: 2010-08-28

Creator: Connor Behan

Private: No

The "trough" case in the do_smooth_draw_shadow function tries to get attirubtes of the variable "part" without making sure part is non-NULL. In fact it is NOT guaranteed to be non-NULL in this function and crashes the new version of xfce4-taskmanager.

Discussion

Connor Behan - 2010-08-28

Fix but possibly not a very good one

careless.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Connor Behan - 2010-09-04

You did this in another place too

carelessv2.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

do_smooth_draw_shadow isn't crashproof

Group

Searches

Help

#4 do_smooth_draw_shadow isn't crashproof

Discussion