Menu

#34 commit.php is inefficient and breaks good records easily

v1.0 (example)
closed-fixed
blentz
None
5
2014-08-12
2010-10-07
Lazy
No

I made a patch which will first try the zone file as a whole. It should be several orders of magnitude faster when editing or importing multiple zones. Record ordering was also changed to "type, host, pri, destination" because otherwise CNAME, MX, NS and other records that depend from A or AAAA records would get easily broken.

This still won't completely fix the problem if you have ns1.example.org as the primary or secondary name server for example.org domain. Every record until "ns1 IN A ..." will still be broken if the commit.php has to iterate one line at a time.

Discussion

  • Lazy

    Lazy - 2010-10-09

    This newer version should fix the nameserver problems.

     
  • Lazy

    Lazy - 2010-10-09

    There seemed to be many SQL injection possibilities in the original version of this file. Serial calculation also looked really weird.

     
  • blentz

    blentz - 2014-08-12

    Resolved in smbind-0.4.8.1.

     
  • blentz

    blentz - 2014-08-12
    • status: open --> closed-fixed
    • assigned_to: blentz
    • Group: --> v1.0 (example)
     

Log in to post a comment.