From: Bruce A. <ba...@gr...> - 2004-08-04 18:15:57
|
> > The thing that would be most useful to me would be a revised list of all > > those characters that I should consider valid in the REGEXP. As I said, > > this will only issue informational warnings, so one can exclude characters > > that gurus might want, if this helps inform the common man. > > 0123456789/.+*|()?^$[] > > covers all the reasonable patterns I can think of for the limited range > of string inputs. Unless I hear otherwise from regexp gurus or other developers, I will modify the code to issue warnings for any regexp characters NOT in the list above. > > > While we're on the topic of silly mistakes, you might also consider a > > > warning if the regex matches only a non-empty substring of the scheduled > > > time. Currently this is silently ignored, but if the user knows what > > > they're doing, it should never happen. Since you've looked at the code, could you provide a patch to issue this warning, if you still think it's a good idea? Cheers, Bruce |