Re: [Smartmontools-support][patch] 5.1-11: Fix smartd offline test enabling

[Bruce A. <ba...@gr...>]

Maciej,

Apparently email to the smartmontools mailing list was being held for
moderation for two weeks without the list admins (including myself) being
notified.  So I only just received this email.

Your patch is of course completely correct, and I'll apply it immediately.  
Thank you very much for noticing this.

Bruce

On Tue, 27 May 2003, Maciej W. Rozycki wrote:

> Hello,
> 
>  The following fix should count as obvious.  Please apply.
> 
>  BTW, smartd refuses to disable/enable offline testing if the automatic
> timer isn't supported, while smartctl executes the command anyway and at
> least one drive seems to respond to this command regardless:
> 
> [the output is shortened a bit]
> # smartctl -i /dev/hda
> 
> === START OF INFORMATION SECTION ===
> Device Model:     ST320423A
> Firmware Version: 3.02
> Device is:        Not in smartctl database [for details use: -P showall]
> ATA Version is:   5
> ATA Standard is:  Exact ATA specification draft version not indicated
> Local Time is:    Tue May 27 17:24:58 2003 CEST
> SMART support is: Available - device has SMART capability.
> SMART support is: Enabled
> 
> # smartctl -c /dev/hda
> 
> === START OF READ SMART DATA SECTION ===
> General SMART Values:
> Off-line data collection status: (0x02)	Offline data collection activity 
> 					completed without error.
> 					Auto Off-line Data Collection: Disabled.
> Self-test execution status:      (   0)	The previous self-test routine completed
> 					without error or no self-test has ever 
> 					been run.
> Total time to complete off-line 
> data collection: 		 (2400) seconds.
> Offline data collection
> capabilities: 			 (0x1d) SMART execute Offline immediate.
> 					No Automatic timer ON/OFF support.
> 					Abort Offline collection upon new
> 					command.
> 					Offline surface scan supported.
> 					Self-test supported.
> 					No Conveyance Self-test supported.
> 					No Selective Self-test supported.
> SMART capabilities:            (0x0003)	Saves SMART data before entering
> 					power-saving mode.
> 					Supports SMART auto save timer.
> Error logging capability:        (0x01)	Error logging supported.
> 					No General Purpose Logging support.
> Short self-test routine 
> recommended polling time: 	 (   2) minutes.
> Extended self-test routine 
> recommended polling time: 	 (  26) minutes.
> 
> # smartctl -o on /dev/hda
> 
> === START OF ENABLE/DISABLE COMMANDS SECTION ===
> Warning: device does not support SMART Automatic Timers.
> 
> SMART Automatic Offline Testing Enabled every four hours.
> 
> # smartctl -c /dev/hda
> 
> === START OF READ SMART DATA SECTION ===
> General SMART Values:
> Off-line data collection status: (0x82)	Offline data collection activity 
> 					completed without error.
> 					Auto Off-line Data Collection: Enabled.
> Self-test execution status:      (   0)	The previous self-test routine completed
> 					without error or no self-test has ever 
> 					been run.
> Total time to complete off-line 
> data collection: 		 (2400) seconds.
> Offline data collection
> capabilities: 			 (0x1d) SMART execute Offline immediate.
> 					No Automatic timer ON/OFF support.
> 					Abort Offline collection upon new
> 					command.
> 					Offline surface scan supported.
> 					Self-test supported.
> 					No Conveyance Self-test supported.
> 					No Selective Self-test supported.
> SMART capabilities:            (0x0003)	Saves SMART data before entering
> 					power-saving mode.
> 					Supports SMART auto save timer.
> Error logging capability:        (0x01)	Error logging supported.
> 					No General Purpose Logging support.
> Short self-test routine 
> recommended polling time: 	 (   2) minutes.
> Extended self-test routine 
> recommended polling time: 	 (  26) minutes.
> 
>  Is it an intended limitation of smartd or just a bug?
> 
>   Maciej
> 
> -- 
> +  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
> +--------------------------------------------------------------+
> +        e-mail: ma...@ds..., PGP key available        +
> 
> smartmontools-5.1-11-smartd-auto-offline.patch
> diff -up --recursive --new-file smartmontools-5.1-11.macro/smartd.c smartmontools-5.1-11/smartd.c
> --- smartmontools-5.1-11.macro/smartd.c	2003-05-06 07:57:05.000000000 +0000
> +++ smartmontools-5.1-11/smartd.c	2003-05-26 23:56:43.000000000 +0000
> @@ -670,7 +670,7 @@ int atadevicescan2(atadevices_t *devices
>  
>    // enable automatic on-line testing
>    if (cfg->autoofflinetest==2){
> -    if (devices->smartval && isSupportAutomaticTimer(devices->smartval) && !ataDisableAutoOffline(fd))
> +    if (devices->smartval && isSupportAutomaticTimer(devices->smartval) && !ataEnableAutoOffline(fd))
>        printout(LOG_INFO,"Device: %s, enabled SMART Automatic Offline Testing.\n",device);
>      else
>        printout(LOG_INFO,"Device: %s, could not enable SMART Automatic Offline Testing.\n",device);
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by:  Etnus, makers of TotalView, The best
> thread debugger on the planet. Designed with thread debugging features
> you've never dreamed of, try TotalView 6 free at www.etnus.com.
> _______________________________________________
> Smartmontools-support mailing list
> Sma...@li...
> https://lists.sourceforge.net/lists/listinfo/smartmontools-support
>