|
From: Alexander S. <ash...@gm...> - 2009-06-29 21:19:02
|
Hello, On Mon, 29 Jun 2009 22:12:15 +0200 Christian Franke <Chr...@t-...> wrote: > This is now fixed in CVS. Using '-l xerror/xselftest' with a JM20337 > device now results in '48-bit ATA commands not supported' message unless > '-d usbjmicron,x' is used. Thanks, just tested it in Linux, works as advertised. It's a shame the "bad" chip revisions can't be detected though. > BTW: Would is make sense to fall back to '-l error/selftest' if only '-l > xerror/xselftest' is specified but does not work? I don't know, maybe, maybe not. It can clutter up the output if the user does something like smartctl -l selftest -l xselftest /dev/sda I'd rather get a selftest log and a message that GPL is unsupported, than two identical selftest logs. On the other hand, this is a highly hypothetical situation. :) Maybe just printing something like "-l xselftest: GPL unsupported, please try -l selftest instead" would be ok too. From gsmartcontrol standpoint, it doesn't really matter as long as I can detect whether GPL is supported or not, and I'm not sure I even need that yet. Thanks a lot, Alexander |