Re: [smartmontools-support] smartmontools compile fix for 5.37

[Christian F. <Chr...@t-...>]

Natanael Copa wrote:
> I'm not sure if its related to my gcc-3 version or that im using 
> uclibc++.
>
>   

The missing const works for newer gcc versions due to a more relaxed 
implicit conversion:
http://article.gmane.org/gmane.linux.utilities.smartmontools/4236/


> details here:
> https://bugs.gentoo.org/show_bug.cgi?id=191346
>
> Shouldn't be any problem to apply it anyway:
>
> diff -u smartmontools-5.37.orig/smartctl.cpp
> smartmontools-5.37/smartctl.cpp
> --- smartmontools-5.37.orig/smartctl.cpp	2007-09-05 09:17:18 +0000
> +++ smartmontools-5.37/smartctl.cpp	2007-09-05 09:17:47 +0000
> @@ -82,7 +82,7 @@
>  }
>  
>  void printcopy(){
> -  char *configargs=strlen(SMARTMONTOOLS_CONFIGURE_ARGS)?SMARTMONTOOLS_CONFIGURE_ARGS:"[no arguments given]";
> +  const char *configargs=strlen(SMARTMONTOOLS_CONFIGURE_ARGS)?SMARTMONTOOLS_CONFIGURE_ARGS:"[no arguments given]";
>  
> ...
>   

Thanks for the patch.

This is already fixed in CVS:
http://smartmontools.cvs.sourceforge.net/smartmontools/sm5/smartctl.cpp?r1=1.156&r2=1.157
http://smartmontools.cvs.sourceforge.net/smartmontools/sm5/smartd.cpp?r1=1.384&r2=1.385

Christian