Menu

#3682 Slashdot's new CSS rules are too generic

Slashdot
open
5
2006-06-07
2006-06-07
No

Main related file: http://images.slashdot.org/comments.css

Several of the new CSS rules are too generic, assuming
for example that all unordered lists (UL tags) in the
comments area are part of the comment hierarchy
(div#contents ul li ul), while comments are also
allowed to use them.

Ideally more specific nesting rules (using ">"
selectors) would solve the problem, but IE lacks
support to them.
My suggestion is to change Slashcode's markup to
include classes on the tree's elements to aid the styling.
A similar problem happens to links, but a kind of a
hack was used to fix it (see comments.css line 35,
"#commentlisting div.commentTop a,", to line 40).

Discussion

  • shane

    shane - 2006-06-07

    Logged In: YES
    user_id=52587

    I think this is more of a feature-request, but I'll second it just the same.

     
  • Matt Sicker

    Matt Sicker - 2006-06-07

    Logged In: YES
    user_id=1088943

    Of course, you could just use the IE7 JS library as well
    for IE. That adds support for selectors.

     
  • Anonymous

    Anonymous - 2006-06-08

    Logged In: YES
    user_id=539453

    It is a bug in the sense of not rendering lists in user
    comments correctly.

    My original intent was to include a link to an example, but
    unfortunately (or fortunately, as it makes this problem much
    less significant) such lists are quite rare and I couldn't
    find the ones I saw before.

    You can still test it by writing a list in the reply box and
    previewing it (minimal testcase: "<ul><li>a<li>b</ul>").

    By the way, while trying the preview, I found another
    aesthetical minor issue: the background of the preview area
    is gray, making the preview slightly visually different from
    the result, and producing a small white corner due to the
    corner-rounding background picture. But I guess that's even
    less important, since nobody previews posts. If you do, you
    must be new here :)

     
  • Raphaël Quinet

    Raphaël Quinet - 2006-06-09

    Logged In: YES
    user_id=8913

    You may also want to look at bug #1502349. I had not seen
    this one when I submitted my bug report. Both reports are
    about similar CSS problems, except that I noted that OL
    lists are also affected. I also suggest a solution and
    link to some comments demonstrating the problems affecting
    these lists.

     

Log in to post a comment.

Monday.com Logo