Menu

#2473 Threshold applied before bonuses?

Slash 2.3/2.4
open
Comments (601)
3
2003-06-17
2003-05-27
Quietust
No

My current 'Comments' settings for score bonuses are
as follows:

Threshold: 2
Highlight Threshold: 3
Hard Thresholds - checked
Reparent Highly Rated Comments - checked

Reason Modifier: all 0
People Modifier: all 0
Anonymous modifier: 0
Karma Bonus: +1
Subscriber Bonus: 0
New User Bonus: 1%, 0
Small/Large Comment Bonus: 0, 0
No Karma Bonus - unchecked

When I view a discussion, the amount of comments that
appear do NOT match the number on the front page (i.e.
if it says "20 of 36 comments", it shows "2: 13
comments" in the threshold combobox). If I temporarily
lower my threshold (i.e. to 1, 0, or -1), then I see 'Score:
2' comments which did not appear previously (adding up
to the number of comments above threshold originally
reported on the front page).

Discussion

  • Rob Malda

    Rob Malda - 2003-05-28
    • assigned_to: nobody --> krow
     
  • Jamie McCarthy

    Jamie McCarthy - 2003-06-17
    • milestone: 101417 --> Slash 2.3/2.4
     
  • Jamie McCarthy

    Jamie McCarthy - 2003-06-17
    • priority: 5 --> 3
    • assigned_to: krow --> cowboyneal
     
  • Jamie McCarthy

    Jamie McCarthy - 2003-06-17

    Logged In: YES
    user_id=3889

    The important thing is that bonus be calculated before we
    apply the threshold to decide whether a comment is
    displayed. If this is just about the popup menu with its
    count of comments, my thinking is that that doesn't need to
    be absolutely precise and we shouldn't waste too much time
    on it... but that's just me...

     
  • Quietust

    Quietust - 2003-07-03

    Logged In: YES
    user_id=56060

    The dropdown box is only a small part of the problem; as it is,
    I never see +2-from-karma-bonus posts unless I drop my
    threshold to 1.

     
  • Michael Torrie

    Michael Torrie - 2003-10-13

    Logged In: YES
    user_id=56824

    From what I can see, any comments that are rated at or above
    your threshhold but are replies to a comment that is below
    your threshold, they do not display at all. This could be a
    preference to some people. Me personally I would like to
    see all the comments that are at or above my threshold,
    regardless of whether or not I can see the parent comment
    (since I view in flat mode).

    Perhaps this observation is wrong it actually is a karma-add
    problem, but this is how the problem appears to me.

     
  • Bob Bell

    Bob Bell - 2003-10-22

    Logged In: YES
    user_id=18297

    I believe I am seeing this problem, and if I am, I
    definitely think it is worthy of fixing. An example of what
    I see:
    Slashdot story "AT&T Moves Toward Mail-Server Whitelist"
    lists "16 of 351 comments". When I click on the "16" and go
    to the story page (sid=03/10/22/0130216), the threshold
    dropdown reads only "4: 13 comments", seemingly implying
    that I am missing some. (Note: I am also reading at "Flat"
    and "Oldest First"). Furthermore, only 7 comments are
    actually displayed (all with score 5), indicating more
    "missing" messages. Additional, the drop-down box reads:
    -1: 13 comments
    0: 13 comments
    1: 13 comments
    2: 13 comments
    3: 13 comments
    4: 13 comments
    5: 12 comments

    If I drop my threshold to "3", I get the following behavior.
    The drop-down box now displays:
    -1: 22 comments
    0: 22 comments
    1: 22 comments
    2: 22 comments
    3: 22 comments
    4: 16 comments
    5: 12 comments
    And actually, only 18 comments are displayed, with scores 3,
    4 and 5 (note that it is now display some comments with
    scores of 4 that I didn't get with my threshold of 4).

    I can think of several reasons why this behavior should be
    considered broken:
    (1) It is either hiding comments that I want to see, or at
    least making me think it is hiding comments that I have said
    that I want to see
    (2) It makes the comment count in the "Threshold" drop-down
    worthless. I'd like to use that to browse at a high
    threshold, and quickly check to see how many messages I
    would get if I lowered my threshold. I can't do that with
    this broken behavior.
    (3) Having such obviously off comment counts results in a
    very negative user opinion (I know because I've been
    thinking "I can't believe how screwed up Slashdot is"!)
    (4) To my knowledge, there is no good workaround (please let
    me know if there is)

    My settings:
    Display Mode: Flat
    Sort Order: Oldest First
    Threshold: 4: Score +4
    Highlist Threshold: 2: Score +2
    Hard Thresholds: checked
    Reparent Highly Rated Comments: checked
    Do Not Display Scores: not checked
    Karma modifier: +1
    Small Comment Penalty: 25, -1
    (All other modifiers at 0)

     

Log in to post a comment.