Menu

#1363 "Shortcuts Control-= and Option-Control-= to auto size text notes" feature doesn't work with Japanese keyboard layout

Other
closed-fixed
nobody
None
3
2020-04-06
2020-03-31
No

Please see Japanese Keyboard Layout https://keyshorts.com/blogs/blog/37615873-how-to-identify-macbook-keyboard-localization#japanese .
With japanese keyboard '=' is typed by Shift--.

I looked at the inplementation of keyDown in SKPDFView.m.

    } else if ([activeAnnotation isText] && (eventChar == '=') && ((modifiers & ~NSAlternateKeyMask) == NSControlKeyMask)) {
        [self doAutoSizeActiveNoteIgnoringWidth:(modifiers & NSAlternateKeyMask) != 0];
    }

I checked eventChar variable is '=' when I type '=' by Shift-- with Japanese keyboard, but doAutoSizeActiveNoteIgnoringWidth doesn't call maybe because of ((modifiers & ~NSAlternateKeyMask) == NSControlKeyMask).

Discussion

  • Christiaan Hofman

    I did not realize this. Will be fixed for the next release.

     
  • Christiaan Hofman

    • status: unread --> open-fixed
     
  • Masahiro Nakamura

    Thanks!

     
  • Christiaan Hofman

    • Status: open-fixed --> closed-fixed
     

Log in to post a comment.