Re: [Sipp-users] Another suggested change

[Olivier J. <oja...@gm...>]

Checked in (SVN 66).

Thanks
Olivier.

On 8/13/06, Peter Higginson <pet...@ne...> wrote:
>
>
>
> Olivier,
>
>
>
> I was wrong in my statement that this change was already covered in the
> current code. Note this is orthogonal to the other changes; it has
> usefulness even if you don't do the others.
>
>
>
> The basic reason for making this change is that you cannot send another
> message until after a previous one is acknowledged. If you receive a CANCEL
> or BYE (and match it) you really want to reply to it. (In our scripts the
> recv of the CANCEL or BYE while waiting for a response has optional="true"
> next="n". After the jump to "n" you want to answer it.)
>
>
>
> There are other ways to do this; you could have some explicit directive
> and/or you could couple it with testing for use of the "next" option in the
> recv. You could alternatively implement a send that either cancelled or did
> not interfere with an existing send with retransmissions. However this is
> what I have done and so far it has seemed enough:
>
>
>
> Change this code in call.cpp (lines 2428-2431):
>
>
>
>   if(((reply_code) ||
>
>       ((!strcmp(request, "ACK")) ||
>
>        (!strcmp(request, "PRACK"))))  &&
>
>      (search_index > last_send_index)) {
>
>
>
> To this:
>
>
>
>   if(((reply_code) ||
>
>       ((!strcmp(request, "ACK")) ||
>
>        (!strcmp(request, "CANCEL")) || (!strcmp(request, "BYE")) ||
>
>        (!strcmp(request, "PRACK"))))  &&
>
>      (search_index > last_send_index)) {
>
>
>
> Regards,
>
> Peter
>
>
>
>
>
> Peter Higginson
>
> Newport Networks Ltd,
>
> Direct line 01494 470694
>
> http://www.newport-networks.com/
>
>
>
>
> ------------------------------
> ---------------
> This e-mail may contain confidential and/or privileged information. If you
> are not the intended recipient (or have received this e-mail in error)
> please notify the sender immediately and delete this e-mail. Any
> unauthorized copying, disclosure or distribution of the contents in this
> e-mail is strictly forbidden.
> ---------------
>



-- 
HP OpenCall Software
http://www.hp.com/go/opencall/