[Sipp-users] Bugs in sipp.cpp

[Peter H. <pet...@ne...>]

Olivier,

I was looking at sipp.cpp from
http://sipp.sourceforge.net/snapshots/sipp.cumulus.2005-11-13.tar.gz on a
rather boring flight (as you do) and noticed the following things that I
think are bugs or poor coding and have the following suggestions:

In lines 727 and 735 of sipp.cpp, the printf should be fprintf(f, otherwise
the screen dumping to file will be missing these bits.

Lines 1148 and 1149 are identical, one should go. (Harmless though.)

At line 1369 should not the 'while(1)' be 'while(len < buffer_size)' because
otherwise a message that did not match would overflow the buffer.

At line 1385 it would be better to add a test '(len > 3) &&' because
otherwise you are testing values before the start of the buffer for the
first 3 characters received.

Peter

Peter Higginson
Newport Networks Ltd,
Direct line 01494 470694
http://www.newport-networks.com/  <http://www.newport-networks.com/>