From: M.H.VanLeeuwen <mh...@sb...> - 2009-01-19 14:13:46
|
Hi, I'm going through my patches and found this one from last July I'd not yet submitted. 17. sipp.cpp (patch.sipp.cpp.econnreset) - close()ing the socket file descriptor and not invalidating may cause the same socket file descriptor to be added to the pollfiles[] and socket[] multiple times if it is re-used by the OS. This leads to really bad behavior by SIPP, e.g. core dumps. I think the code after the else statement added by this patch is wrong since close()ing the socket->ss_fd will leave the sockfd in the socket[] and pollfiles[] so that subsequent uses of the sockfd by sipp may attempt to add the same sockfd to these arrays again. Martin |