[Sipp-users] [ sipp-Bugs-1821968 ] FileContents class improvments

[SourceForge.net <no...@so...>]

Bugs item #1821968, was opened at 2007-10-29 08:37
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=637564&aid=1821968&group_id=104305

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Simon Flannery (s1m0nflann3ry)
Assigned to: Nobody/Anonymous (nobody)
Summary: FileContents class improvments

Initial Comment:
In relation to the FileContents class, the following bugs / defeats have been identified and rememdied. Also other improvements have been made.

1. Simplified the constructor and improved the file parsing
   - No need for the use of the input file stream pointer
   - Injection files may now contain head comments
   - Injection files may now contain blanks lines/rows
   - The input file stream is now explicitly closed
2. Line selection strategy now defaults to SEQUENTIAL
3. Changed interface int's to size_t
4. Simplified how the next line/row is calculated
5. Removed unneeded 'numLinesInFile' variable
6. Improved field selection algorithm
   - No need for the final field to end with a semi colon! This allow for files to be generated and exported from MS Excel, without modification.
7. The field delimiter, traditionally a semi-colon, is now defined as a FIELD_DELIMITER definition in the header (infile.hpp)
8. Improved the "dump" algorithm
9. Added destructor
10. That's all folks, oh and there were NO INTERFACE CHANGES, but I wanted to

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=637564&aid=1821968&group_id=104305