#75 support inline images

[Samuel Sieb]

A user of the OCS client can send handwriting messages using a tablet. This gets sent as a message with mimetype image/gif:
User-Agent: UCCP/2.0.6362.0 OC/2.0.6362.0 (Microsoft Office Communicator)
Supported: timer
Content-Type: image/gif
Content-Length: 5447

base64:R0lGODlhlwFwAPcAAAAAAAAAMwAAZ...

As far as I can tell, Pidgin can support inline images if the protocol does, so it would be nice to have this implemented.

[Stefan Becker]

Ticket moved from /p/sipe/bugs/261/

Can't be converted:

• _milestone: 1.18.x

[Stefan Becker]

This is not a bug

[Stefan Becker]

Please attach a --debug log.

[Stefan Becker]

I poked around a little bit and I'm sure I know how to implement the libpurple side of things.

But I have no idea about the message format. As I don't have access to Windows or the official client I need you to attach your log data. The truncated information you put into the description is unfortunately not enough to implement this.

[Stefan Becker]

PING? Can you please attach the log? Thank you.

[chagn]

(edited to make the pasted log content more readable)
hello Stefan,

In order to get an inline image, my friend paste an image in his skype for business window.
I've launched pidgin with the --debug option, it seems the interresting area is this one:

(10:01:59) sipe: got message from sip:myemail@tt.ttt: Application-Name: File Transfer
Application-GUID: {5D3E02AB-6190-11d3-BBBB-00C04F795683}
Invitation-Command: INVITE
Invitation-Cookie: 54026176
Application-File: 711FEDA2.PNG
Application-FileSize: 1731
Connectivity: N
Encryption: R

is it enough or do you need more info ?
thanks

[Stefan Becker]

@chagn I would need to see more of the debug log, at least the complete SIP message before the sipe: got message... line. Please note that SIPE will not dump raw messages to the debug log unless you enable unsafe debugging (see FAQ).

Does any of the information you copy&pasted show up in the IM window?

[chagn]

(edited to make the pasted content more readable)
@Stefan Becker, here is the SIP message:

MESSAGE START <<<<<<<<<< SIP - 2018-03-21T13:32:14.216233Z
MESSAGE sip:xxx.86:64218;transport=tls;ms-opaque=d3470f2e1d;ms-received-cid=7879900;grid SIP/2.0
Via: SIP/2.0/TLS xxx.56:5061;branch=z9hG4bKCF39EAC5.285955453AA0178E;branched=FALSE;ms-internal-info="cmNfFoQSIHfAcRI5m4q87baXzxU6qpRWK_SIaqN61wAqdFVVkoUVouzgAA"
Authentication-Info: TLS-DSK qop="auth", opaque="041364D9", srand="647213DE", snum="29", rspauth="77ef542cb817df38fc8e1863b9eb3fd9027d401c", targetname="GMU103.xxx.net", realm="SIP Communications Service", version=4
Max-Forwards: 68
Via: SIP/2.0/TLS xxx.58:58085;branch=z9hG4bK8BCF8B73.E3E456649FE9F78D;branched=FALSE;ms-received-port=58085;ms-received-cid=73A9E00
Via: SIP/2.0/TLS xxx.187:54041;ms-received-port=54041;ms-received-cid=10665200
Content-Length: 242
From: "" <sip:s@r.com>;epid=b7bfad1181;tag=b512b1adec
To: ""<sip:d@r.com>;tag=82254700;epid=066e65940d65
Call-ID: 440Eg2C92a5C4Ci0A43m5DDAt76CEb3DEAx13B0x
CSeq: 4 MESSAGE
User-Agent: UCCAPI/16.0.4654.1000 OC/16.0.4654.1000 (Skype for Business)
Supported: ms-dialog-route-set-update
Supported: timer
Content-Type: text/x-msmsgsinvite; charset=UTF-8

Application-Name: File Transfer
Application-GUID: {5D3E02AB-6190-11d3-BBBB-00C04F795683}
Invitation-Command: INVITE
Invitation-Cookie: 54026177
Application-File: AC1F9D3B.PNG
Application-FileSize: 1616
Connectivity: N
Encryption: R


MESSAGE END <<<<<<<<<< SIP - 2018-03-21T13:32:14.216233Z

on my IM window, I can see:

s is offering to send file AC1F9D3B.PNG
(2:32:20 PM) Starting transfer of AC1F9D3B.PNG from s
(2:32:26 PM) You cancelled the transfer of AC1F9D3B.PNG

[Stefan Becker]

@chagn your log looks different than the one from the original reporter.

Your log shows that the Windows client is trying to initiate an old-style non-Lync File Transfer. I can only guess that the Windows clients use that as indication for "inline image". Or maybe your SIPE is compiled without Lync FT support (see the "About SIPE plugin..." window) and therefore after the request for Lync FT fails, it falls back to old style FT (can't tell, because I have only seen one message from the debug log).

Old-style File Transfer is tricky to get working at all when there firewalls between the clients, because it assumes that TCP ports 6891 to 6901 are accessible on the sending side. That is probably the reason why you see the file transfer failure message.

[Stefan Becker]

@chagn I think the case you described is actually not an inline image at all. I think what happens is that the Windows client initiates a file transfer when you drag a file from the desktop and drop it onto an IM window.

[chagn]

@Stefan Becker,
hmmm, I'm not sure now what is an inline image.... Is it a small picture in teh buddy list (along the user name) ?

indeed, my friend has copied a small picture in his chat window (skype for Business, with CTL+V). The image is then displayed in his chat window and initiates a file transfer on my side (Pidgin).

It seems as well my plugin doesn't have the file transfer feature support, this is the first line
of the about SIPE plugin text:
SIPE 1.23.2 (SSPI)

I've downloaded the plugin from sourceforge and my OS is windows. Does it mean I need the file transfer feature in order to display an image in teh chat window?

thanks

[Stefan Becker]

@chagn

hmmm, I'm not sure now what is an inline image..

Like the original author wrote: "A user of the OCS client can send handwriting messages using a tablet"

Is it a small picture in teh buddy list (along the user name) ?

No, that's the buddy icon and something completely different. SIPE supports those and they are displayed in the Pidgin buddy list.

this is the first line of the about SIPE plugin text: SIPE 1.23.2 (SSPI)

Lync File Transfer is based on the same technologies as Voice & Video calls and Application sharing. Those are not available at all in Windows Pidgin 2.x. That situation might change for WIndows Pidgin 3.x.