simpletest-support

[Simpletest-support] Cannot mock if there is a protected abstract function

[Nicolas T. <nic...@gm...>]

Hi,

<?php

abstract class A {

    protected abstract function internal();

    public function hello() {
        return $this->internal();
    }
}
Mock::generate('A');

class AbstractTest extends UnitTestCase {

    function test_m() {
        $o = new MockA($this);
        $o->setReturnValue('hello', 123);
    }

}

?>

Fatal error: Class MockA contains 1 abstract method and must therefore
be declared abstract or implement the remaining methods (A::internal)

Is it a bug?

Thanks,
Nicolas Terray

Re: [Simpletest-support] Cannot mock if there is a protected abstract function

[Marcus B. <ma...@wo...>]

Hi...

Nicolas Terray wrote:
> Is it a bug?

Yes.

My next chance to look at this will be towards the end of next week.
SimpleTest has two strategies for mocking, subclassing or creating a
fake class with an identical interface. In this case it tried to
subclass when it wasn't capable. This should be easily fixable.

> 
> Thanks,
> Nicolas Terray

yours, Marcus

Re: [Simpletest-support] Cannot mock if there is a protected abstract function

[Manuel V. <man...@gm...>]

On Wed, Oct 21, 2009 at 9:59 PM, Marcus Baker <ma...@wo...> wrote:
> Hi...
>
> Nicolas Terray wrote:
>> Is it a bug?
>
> Yes.
>
> My next chance to look at this will be towards the end of next week.
> SimpleTest has two strategies for mocking, subclassing or creating a
> fake class with an identical interface. In this case it tried to
> subclass when it wasn't capable. This should be easily fixable.

Hello Marcus,

Just for my understanding, if it's not too long to explain, when do
you subclass and when do you "fake class" ?

I realize it's probably why it's not possible to use proper type
hinting with mocked objects.

Manuel

Re: [Simpletest-support] Cannot mock if there is a protected abstract function

[Manuel V. <man...@gm...>]

On Thu, Oct 22, 2009 at 1:16 PM, Manuel Vacelet
<man...@gm...> wrote:
> On Wed, Oct 21, 2009 at 9:59 PM, Marcus Baker <ma...@wo...> wrote:
>> Hi...
>>
>> Nicolas Terray wrote:
>>> Is it a bug?
>>
>> Yes.
>>
>> My next chance to look at this will be towards the end of next week.
>> SimpleTest has two strategies for mocking, subclassing or creating a
>> fake class with an identical interface. In this case it tried to
>> subclass when it wasn't capable. This should be easily fixable.
>
> Hello Marcus,
>
> Just for my understanding, if it's not too long to explain, when do
> you subclass and when do you "fake class" ?
>
> I realize it's probably why it's not possible to use proper type
> hinting with mocked objects.

I just tested the SVN version of simpletest and the problem I
highlight is fixed. Sorry for the noise!

Manuel

Re: [Simpletest-support] Cannot mock if there is a protected abstract function

[Marcus B. <ma...@wo...>]

Hi...

Manuel Vacelet wrote:
> Just for my understanding, if it's not too long to explain, when do
> you subclass and when do you "fake class" ?

It does a bit of reflection to gather information about methods,
such as "final" or "abstract" and then makes a decision. I think
it's set up in the static method Mock::generate(), or not far down
from there, in mock_objects.php.

> 
> I realize it's probably why it's not possible to use proper type
> hinting with mocked objects.

It is possible :). You might need the latest version though, and PHP
5.0.1 and PHP 5.0.2 are problematic due to some limitations on PHP's
reflection support in these versions.

> 
> Manuel
> 

yours, Marcus