simpletest-support — Help, advice, bugs and workarounds.

Re: [Simpletest-support] Question on backwards compatibility and testing web output

[Marcus B. <ma...@wo...>]

Hi...

Travis Swicegood wrote:
> Does anyone see any reason why we might need a BC mode so people can  
> use this code the old way?  If not, I'm going to fix it.

Go right ahead!

> 
> Also, I have a test case that will show that no data has been  
> submitted, but it requires a simple POST variable.  Who do I need to  
> talk to do get some code added to simpletest.org so I can use that for  
> the test?

I don't understand the problem?

> 
> -T

yours, Marcus

[Simpletest-support] Question on backwards compatibility and testing web output

[Travis S. <dev...@do...>]

Hey guys;

We have a buggy implementation in our SimpleMultipartEncoding code as  
noted here:
	https://sourceforge.net/tracker/?func=detail&atid=547455&aid=2151981&group_id=76550

Does anyone see any reason why we might need a BC mode so people can  
use this code the old way?  If not, I'm going to fix it.

Also, I have a test case that will show that no data has been  
submitted, but it requires a simple POST variable.  Who do I need to  
talk to do get some code added to simpletest.org so I can use that for  
the test?

-T

[Simpletest-support] simple test

[Dan Yi <dy...@ha...>]

hi, all

i have a php file "getfile.php"  that need to test. i also create an simple test file and include that file as below:
<?php
require_once("getfile.php");

class TestOfFileFunctions extends UnitTestCase {
  function test_pass() {
     $x = 1;
     $y = 2;
     $total = $x + $y;
     $this->assertEqual(3, $total, "This should pass");
  }
}
?>

problem is getfile.php requires pass 2 parameters into it, when i run simpleTest again this above test file, it won't perform the test, instead it told me getfile.php need 2 parameters to pass into...  how can i test it?   

Thanks!!!

Re: [Simpletest-support] Code coverage

[Marcus B. <ma...@wo...>]

Hi...

Douglas Hubler wrote:
> I'd really like to merge this to trunk.  I can continue to make improvements on
> trunk. I will merge trunk into this branch before trying to merge to trunk.

I won't be able to look at it until after Xmas now. I'm going to do a
bit of a stint to get a tarball out around then as well. Hopefully we
can include the coverage stuff in the code for people to try out
(unofficially first).

yours, Marcus

Re: [Simpletest-support] Code coverage

[Douglas H. <dh...@gm...>]

Douglas Hubler <dhubler@...> writes:
> Perrick Penet <perrick@...> writes:
> > - there's not only a dependcy upon SQLlite but also on PEAR's DB/sqlite. 
> > Could we get rid of PEAR first ?
> I installed sqlite from ubuntu package. Can you give advice, on what i can 
> do to remove PEAR, I'm not too familiar with this.

I'm still not sure what do here

> > - there's a "test.php" file in the /coverage directory, I think it 
> > should be put into /coverage/test/

fixed

> > - the /test/sample-code.php should move up one level into something like 
> > /test/sample/code.php

fixed

> > - while I'm at it, shouldn't we move /coverage/CoverageTemplates to 
> > /coverage/templates

fixed

I'd really like to merge this to trunk.  I can continue to make improvements on
trunk. I will merge trunk into this branch before trying to merge to trunk.

Re: [Simpletest-support] In/Out parameters & Mocks

[Nicolas T. <nic...@gm...>]

On Sun, Dec 14, 2008 at 6:19 PM, Marcus Baker <ma...@wo...> wrote:
> I haven't tested this code (my kids are runing around undreneath my
> feet), but it should work.
>

Just a little typo:
$bar = parent::bar($b);   =====>   $b = parent::bar($b);

It's perfect, it works!

> I've made a mental note that a future version should take care of this
> more naturally.
>

Usage of in/out parameters is not really common but pretty handy in
some cases :)

Many thanks,
Nicolas

Re: [Simpletest-support] In/Out parameters & Mocks

[Marcus B. <ma...@wo...>]

Hi...

Nicolas Terray wrote:
> class Foo {
>     public function bar(&$b) {
>         $b = 666;
>     }
> }

I find it hard to follow "foo" and "bar" examples, but the the exact
case you've presented is very difficult. You would have to subclass the
mock...

class Foo {
    public function bar(&$b) {
        $b = 666;
    }
}
Mock::generate('Foo', 'BaseMockFoo');

class MockFoo extends BaseMockFoo {
    function bar(&$b) {
        $bar = parent::bar($b);
    }
}

class InOutTest extends UnitTestCase {
    function testInOut() {
        $o = new InOut();

        $foo1 = new Foo();
        $this->assertEqual(666, $o->hello($foo1)); // This pass

        $foo2 = new MockFoo($this);
        $foo2->setReturnValue('bar', 111);
        $this->assertEqual(111, $o->hello($foo2));
    }
}


> 
> Any help is welcome :)

I haven't tested this code (my kids are runing around undreneath my
feet), but it should work.

I've made a mental note that a future version should take care of this
more naturally.

> 
> Best,
> Nicolas Terray

yours, Marcus

[Simpletest-support] In/Out parameters & Mocks

[Nicolas T. <nic...@gm...>]

Hi,

I would like to test the behavior of a method which deals with in &
out parameters.
Here is a basic test case.

---8<---------
class InOut {
    public function hello($foo) {
        $a = 1;
        $foo->bar($a);
        return $a;
    }
}
class Foo {
    public function bar(&$b) {
        $b = 666;
    }
}
Mock::generate('Foo');
class InOutTest extends UnitTestCase {
    function testInOut() {
        $o = new InOut();

        $foo1 = new Foo();
        $this->assertEqual(666, $o->hello($foo1)); // This pass

        $foo2 = new MockFoo($this);
        $foo2->set......('bar', 111);               // ???
        $this->assertEqual(111, $o->hello($foo2));
    }
}
---8<---------

How can I do that?

Any help is welcome :)

Best,
Nicolas Terray

[Simpletest-support] autotest

[troels knak-n. <tro...@gm...>]

Hi list,

Inspired by [ZenTest/autotest](http://zentest.rubyforge.org/ZenTest/),
I made a small shell script, for continuously running tests in the
background.
It relies on inotify-tools and the gnome-specific notify-send. It can
probably be easily ported to other unix systems, by replacing
notify-send with something like growl for OS X. I'm not sure about how
portable inotify-tools is though.

--
troels

Re: [Simpletest-support] Error in PHP Unt test

[Steven B. <ste...@gm...>]

On Tue, Dec 2, 2008 at 9:29 PM, arpit agarwal <arp...@ya...> wrote:
> Hi,
>
> As i extract the source file i got the eclipse.php and unit_tester.php with
> other files and i had placed at mention path yet it is given error on
> console.I am using PHP 5
>
>
> unning:
>
> echo "<?php
> $path='C:\simpletest_1.0.1.eclipse_0.2.4';ini_set('include_path',
> get_include_path().PATH_SEPARATOR .
> realpath($path));ini_set('html_errors','0');$fullpath =
> realpath('C:/PHP/workspace/fckEditorSample/fckeditor/test.test.php');$pathparts
> = pathinfo($fullpath);$filename =
> $pathparts['basename'];include_once('xml.php');include_once('unit_tester.php');include_once('mock_objects.php');include_once('test_case.php');include_once('invoker.php');$test=new
> GroupTest($filename);$test->addTestFile($fullpath);$test->run(new
> XmlReporter()); ?>" | "C:\Program Files\PHP\php.exe" -q -c "C:\Program
> Files\PHP\php.ini"
>
> *************
>
> PHP Warning: include_once(eclipse.php): failed to open stream: No such file
> or directory in C:\Documents and Settings\arpit716\Local
> Settings\Temp\Simpletest54908.php on line 1
>
> PHP Stack trace:
>
> PHP 1. {main}() C:\Documents and Settings\arpit716\Local
> Settings\Temp\Simpletest54908.php:0
>
> PHP Warning: include_once(): Failed opening 'eclipse.php' for inclusion
> (include_path='C:\PHP\workspace\AIJoabBoard2008\src;C:\simpletest_1.0.1.eclipse_0.2.4')
> in C:\Documents and Settings\arpit716\Local
> Settings\Temp\Simpletest54908.php on line 1
>
> PHP Stack trace:
>
> PHP 1. {main}() C:\Documents and Settings\arpit716\Local
> Settings\Temp\Simpletest54908.php:0
>
> PHP Fatal error: Class 'GroupTest' not found in C:\Documents and
> Settings\arpit716\Local Settings\Temp\Simpletest54908.php on line 1
>
> PHP Stack trace:
>
> PHP 1. {main}() C:\Documents and Settings\arpit716\Local
> Settings\Temp\Simpletest54908.php:0
>
> Process returned: 255
>
> Thanks
> Arpit


I think you misunderstood my instructions from yesterday.  You should
not move the files eclipse.php and unit_tester.php; you should change
the path in the eclipse preferences to point to the correct directory.
 The directory that you select in the preferences needs to have
eclipse.php and unit_tester.php in it, but it should have the rest of
the simpletest files also.  Your path is still not correct.

One way to absolutely solve this problem is:
1. download the simpletest_1.0.1 tarball from:
http://sourceforge.net/project/showfiles.php?group_id=76550
2. extract this tarball to your local machine
3. find the directory from the extracted tarball which has the files:
eclipse.php and unit_tester.php -- copy the path for this directory
into the Simpletest preferences in eclipse.

Regards,
Steven Balthazor

Re: [Simpletest-support] Error in PHP Unt test

[arpit a. <arp...@ya...>]

Hi,
 
As i extract the source file i got the eclipse.php and unit_tester.php with other files and i had placed at mention path yet it is given error on console.I am using PHP 5
 
unning: 
echo "<?php $path='C:\simpletest_1.0.1.eclipse_0.2.4';ini_set('include_path', get_include_path().PATH_SEPARATOR . realpath($path));ini_set('html_errors','0');$fullpath = realpath('C:/PHP/workspace/fckEditorSample/fckeditor/test.test.php');$pathparts = pathinfo($fullpath);$filename = $pathparts['basename'];include_once('xml.php');include_once('unit_tester.php');include_once('mock_objects.php');include_once('test_case.php');include_once('invoker.php');$test=new GroupTest($filename);$test->addTestFile($fullpath);$test->run(new XmlReporter()); ?>" | "C:\Program Files\PHP\php.exe" -q -c "C:\Program Files\PHP\php.ini"
*************
PHP Warning: include_once(eclipse.php): failed to open stream: No such file or directory in C:\Documents and Settings\arpit716\Local Settings\Temp\Simpletest54908.php on line 1
PHP Stack trace:
PHP 1. {main}() C:\Documents and Settings\arpit716\Local Settings\Temp\Simpletest54908.php:0
PHP Warning: include_once(): Failed opening 'eclipse.php' for inclusion (include_path='C:\PHP\workspace\AIJoabBoard2008\src;C:\simpletest_1.0.1.eclipse_0.2.4') in C:\Documents and Settings\arpit716\Local Settings\Temp\Simpletest54908.php on line 1
PHP Stack trace:
PHP 1. {main}() C:\Documents and Settings\arpit716\Local Settings\Temp\Simpletest54908.php:0
PHP Fatal error: Class 'GroupTest' not found in C:\Documents and Settings\arpit716\Local Settings\Temp\Simpletest54908.php on line 1
PHP Stack trace:
PHP 1. {main}() C:\Documents and Settings\arpit716\Local Settings\Temp\Simpletest54908.php:0
Process returned: 255

Thanks
Arpit
--- On Tue, 2/12/08, Steven Balthazor <ste...@gm...> wrote:

From: Steven Balthazor <ste...@gm...>
Subject: Re: [Simpletest-support] Error in PHP Unt test
To: arp...@ya..., "Help, advice, bugs and workarounds" <sim...@li...>
Date: Tuesday, 2 December, 2008, 8:10 PM

On Mon, Dec 1, 2008 at 11:27 PM, arpit agarwal <arp...@ya...>
wrote:
> Hi,
>
> I have followed all proper steps stated in Read me and all are
successfully done but there are no option is coming in eclipse while creating a
ner project as sample as stated in Docs.
>
> And while i am trying to Run Test Case as Run As Simple test as option
started coming
> Its giving error
>
> Running:
> echo "<?php
$path='C:\simpletest_1.0.1.eclipse_0.2.4\plugins';ini_set('include_path',
get_include_path().PATH_SEPARATOR .
realpath($path));ini_set('html_errors','0');$fullpath =
realpath('C:/PHP/workspace/fckEditorSample/fckeditor/test.test.php');$pathparts
= pathinfo($fullpath);$filename =
$pathparts['basename'];include_once('xml.php');include_once('unit_tester.php');include_once('mock_objects.php');include_once('test_case.php');include_once('invoker.php');$test=new
GroupTest($filename);$test->addTestFile($fullpath);$test->run(new
XmlReporter()); ?>" | "C:\Program
Files\PHP\php.exe" -q -c "C:\Program
Files\PHP\php.ini"
> *************
> Process returned: 255
> Process error:
> PHP Warning: include_once(eclipse.php): failed to open stream: No such
file or directory in C:\Documents and Settings\arpit716\Local
Settings\Temp\Simpletest14634.php on line 1
> PHP Stack trace:
> PHP 1. {main}() C:\Documents and Settings\arpit716\Local
Settings\Temp\Simpletest14634.php:0
> PHP Warning: include_once(): Failed opening 'eclipse.php' for
inclusion
(include_path='.;C:\php5\pear;C:\simpletest_1.0.1.eclipse_0.2.4\plugins')
in C:\Documents and Settings\arpit716\Local
Settings\Temp\Simpletest14634.php on line 1


The path that you have set for Simpletest is wrong.  According to the
trace, Simpletest is trying to load from the path:
"C:\simpletest_1.0.1.eclipse_0.2.4\plugins".  Open that
directory and
verify that this directory contains the files: eclipse.php and
unit_tester.php (among many others).  If the directory is incorrect
then change the directory in Eclipse by selecting "Windows" ->
"Preferences"; then selecting the Simpletest option from the left
hand
column; then insert the correct path into the "Simpletest Path:"
entry.

Regards,
Steven Balthazor

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's
challenge
Build the coolest Linux based applications with Moblin SDK & win great
prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Simpletest-support mailing list
Sim...@li...
https://lists.sourceforge.net/lists/listinfo/simpletest-support



      Get perfect Email ID for your Resume. Grab now http://in.promos.yahoo.com/address

Re: [Simpletest-support] Roadmap for simpletest

[Marcus B. <ma...@wo...>]

Hi...

Florin Miu wrote:
> Hello,I'm starting to build my own php5 framework and I'm going to use TDD. I have to choose between simpletest and phpunit but simple test is not php5 ready yet. Is there a roadmap for the development for simpletest?Also what is the best way to test database abstraction classes (connecting, returning recordsets)? I've seen PHPUnit has a database extension for this purpose. Is there a way to do this with simple test?Thanks.

The current version works with PHP5, but not under E_STRICT due to 
PHP4 compatibility.

The SVN version (1.1) works with PHP5 (E_STRICT). Just do an SVN 
checkout from Sourceforge. We are trying to push compatibility back 
to PHP 5.0.3, so haven't formally released the code yet.

As for the DB testing, what are you trying to do?

We don't have an explicit DB extension, but usage tends to vary 
quite a bit.

> Florin

yours, Marcus

[Simpletest-support] Roadmap for simpletest

[Florin M. <flo...@ya...>]

Hello,I'm starting to build my own php5 framework and I'm going to use TDD. I have to choose between simpletest and phpunit but simple test is not php5 ready yet. Is there a roadmap for the development for simpletest?Also what is the best way to test database abstraction classes (connecting, returning recordsets)? I've seen PHPUnit has a database extension for this purpose. Is there a way to do this with simple test?Thanks.
Florin



      

Re: [Simpletest-support] Error in PHP Unt test

[Steven B. <ste...@gm...>]

On Mon, Dec 1, 2008 at 11:27 PM, arpit agarwal <arp...@ya...> wrote:
> Hi,
>
> I have followed all proper steps stated in Read me and all are successfully done but there are no option is coming in eclipse while creating a ner project as sample as stated in Docs.
>
> And while i am trying to Run Test Case as Run As Simple test as option started coming
> Its giving error
>
> Running:
> echo "<?php $path='C:\simpletest_1.0.1.eclipse_0.2.4\plugins';ini_set('include_path', get_include_path().PATH_SEPARATOR . realpath($path));ini_set('html_errors','0');$fullpath = realpath('C:/PHP/workspace/fckEditorSample/fckeditor/test.test.php');$pathparts = pathinfo($fullpath);$filename = $pathparts['basename'];include_once('xml.php');include_once('unit_tester.php');include_once('mock_objects.php');include_once('test_case.php');include_once('invoker.php');$test=new GroupTest($filename);$test->addTestFile($fullpath);$test->run(new XmlReporter()); ?>" | "C:\Program Files\PHP\php.exe" -q -c "C:\Program Files\PHP\php.ini"
> *************
> Process returned: 255
> Process error:
> PHP Warning: include_once(eclipse.php): failed to open stream: No such file or directory in C:\Documents and Settings\arpit716\Local Settings\Temp\Simpletest14634.php on line 1
> PHP Stack trace:
> PHP 1. {main}() C:\Documents and Settings\arpit716\Local Settings\Temp\Simpletest14634.php:0
> PHP Warning: include_once(): Failed opening 'eclipse.php' for inclusion (include_path='.;C:\php5\pear;C:\simpletest_1.0.1.eclipse_0.2.4\plugins') in C:\Documents and Settings\arpit716\Local Settings\Temp\Simpletest14634.php on line 1


The path that you have set for Simpletest is wrong.  According to the
trace, Simpletest is trying to load from the path:
"C:\simpletest_1.0.1.eclipse_0.2.4\plugins".  Open that directory and
verify that this directory contains the files: eclipse.php and
unit_tester.php (among many others).  If the directory is incorrect
then change the directory in Eclipse by selecting "Windows" ->
"Preferences"; then selecting the Simpletest option from the left hand
column; then insert the correct path into the "Simpletest Path:"
entry.

Regards,
Steven Balthazor

[Simpletest-support] Error in PHP Unt test

[arpit a. <arp...@ya...>]

Hi,
 
I have followed all proper steps stated in Read me and all are successfully done but there are no option is coming in eclipse while creating a ner project as sample as stated in Docs.
 
And while i am trying to Run Test Case as Run As Simple test as option started coming
Its giving error
 
Running: 
echo "<?php $path='C:\simpletest_1.0.1.eclipse_0.2.4\plugins';ini_set('include_path', get_include_path().PATH_SEPARATOR . realpath($path));ini_set('html_errors','0');$fullpath = realpath('C:/PHP/workspace/fckEditorSample/fckeditor/test.test.php');$pathparts = pathinfo($fullpath);$filename = $pathparts['basename'];include_once('xml.php');include_once('unit_tester.php');include_once('mock_objects.php');include_once('test_case.php');include_once('invoker.php');$test=new GroupTest($filename);$test->addTestFile($fullpath);$test->run(new XmlReporter()); ?>" | "C:\Program Files\PHP\php.exe" -q -c "C:\Program Files\PHP\php.ini"
*************
Process returned: 255
Process error:
PHP Warning: include_once(eclipse.php): failed to open stream: No such file or directory in C:\Documents and Settings\arpit716\Local Settings\Temp\Simpletest14634.php on line 1
PHP Stack trace:
PHP 1. {main}() C:\Documents and Settings\arpit716\Local Settings\Temp\Simpletest14634.php:0
PHP Warning: include_once(): Failed opening 'eclipse.php' for inclusion (include_path='.;C:\php5\pear;C:\simpletest_1.0.1.eclipse_0.2.4\plugins') in C:\Documents and Settings\arpit716\Local Settings\Temp\Simpletest14634.php on line 1
PHP Stack trace:
PHP 1. {main}() C:\Documents and Settings\arpit716\Local Settings\Temp\Simpletest14634.php:0
PHP Fatal error: Class 'GroupTest' not found in C:\Documents and Settings\arpit716\Local Settings\Temp\Simpletest14634.php on line 1
PHP Stack trace:
PHP 1. {main}() C:\Documents and Settings\arpit716\Local Settings\Temp\Simpletest14634.php:0

Read error:Read error
[Ljava.lang.StackTraceElement;@1220c1b
 
Please find out the problem if any in Installation.Lookin forword for positive responce
 
Thanks
Arpit Agarwal
(+91)9899655375
 
 


      Add more friends to your messenger and enjoy! Go to http://messenger.yahoo.com/invite/

Re: [Simpletest-support] Code coverage

[Douglas H. <dh...@gm...>]

Perrick Penet <perrick@...> writes:
> First of all thank you so much for this contribution !

thanks for the review

> - there's not only a dependcy upon SQLlite but also on PEAR's DB/sqlite. 
> Could we get rid of PEAR first ?

I installed sqlite from ubuntu package. Can you give advice, on what i can do to
remove PEAR, I'm not too familiar with this.

> - there's a "test.php" file in the /coverage directory, I think it 
> should be put into /coverage/test/

sure.  

I can reword this doc too, it doesn't make this clear
http://simpletest.sourceforge.net/en/writing_extensions.html

> 
> - the /test/sample-code.php should move up one level into something like 
> /test/sample/code.php (that way we also remove the "-" in the filename, 
> "_" are used all over the place in SimpleTest code base)

sure

> 
> - while I'm at it, shouldn't we move /coverage/CoverageTemplates to 
> /coverage/templates
sure

> 
> I'll send over an other set of remarks once I have PEAR installed on my 
> machine.
thank you

Re: [Simpletest-support] Code coverage

[Perrick P. <pe...@no...>]

Hi Douglas,

First of all thank you so much for this contribution !

Now for my remarks :

- there's not only a dependcy upon SQLlite but also on PEAR's DB/sqlite. 
Could we get rid of PEAR first ?

- there's a "test.php" file in the /coverage directory, I think it 
should be put into /coverage/test/

- the /test/sample-code.php should move up one level into something like 
/test/sample/code.php (that way we also remove the "-" in the filename, 
"_" are used all over the place in SimpleTest code base)

- while I'm at it, shouldn't we move /coverage/CoverageTemplates to 
/coverage/templates

I'll send over an other set of remarks once I have PEAR installed on my 
machine.

Yours,
	Perrick





Douglas Hubler wrote:
> Jakob Ketterl <jketterl@...> writes:
>> I found two little bugs in the reporting templates (it's just missing echo 
>> statements). i'm including a patch 
> thanks, i committed these
> 
> Any progress on general review?
> 
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Simpletest-support mailing list
> Sim...@li...
> https://lists.sourceforge.net/lists/listinfo/simpletest-support
> 
> 

Re: [Simpletest-support] Code coverage

[Douglas H. <dh...@gm...>]

 (2nd post, gmane may have ate first)

Jakob Ketterl <jketterl@...> writes:
> On Tuesday 18 November 2008 06:13:16 Douglas Hubler wrote:
> > Any progress on general review?
> i didn't use the concept of an external shell script 

excellent, i almost didn't write shell script so folks would use the API

> i've read in the source that uncovered files are scanned for from getcwd() 
y, we can make that configurable


> i've also had a look into what's inside the sqlite file, and from my point of 
> view the structure doesn't look that complicated, imho that's nothing a 
> serialized array couldn't handle (if it really needs to be stored to disk - 
> for my case it's not even necessary).

in my case, i generate a lot of data and sqlite helps me from loading entire
coverage into memory. All of sqlite functionality is in CoverageDataHandler so
it can be replaces or we can have alternate implementations no problem

> i think it would be better to integrate this deeper into the simpletest main 
> code, but that's beyond the scope of "extension", if i'm correct...

extension can know about simpletest, simpletest probably shouldn't know
extension directly, however... the

for report data, yes, i could see some integration there.  

for coverage data, although i initiate test from simpletest, web tests make http
requests to my web server and i need to gather coverage data there. Nothing is
known about simpletest there.

Re: [Simpletest-support] Code coverage

[Douglas H. <dh...@gm...>]

Jakob Ketterl <jketterl@...> writes:
> On Tuesday 18 November 2008 06:13:16 Douglas Hubler wrote:
> > Jakob Ketterl <jketterl@...> writes:
> > > I found two little bugs in the reporting templates (it's just missing
> > > echo statements). i'm including a patch
> >
> > thanks, i committed these
> >
> > Any progress on general review?
> 
> yes, i've even managed to integrate it with phpundercontrol (using a special 
> reporter class i've hacked up myself).
> 
> however, i didn't use the concept of an external shell script to separate 
> coverage setup/collection from the actual test run

that's great, my goal was to give folks APIs for custom setups, i almost didn't
create shell script to encourage folks to do just what you did, but then i
thought we'd loose the folks that just wanted to follow a simple pattern.

> i've read in the source that uncovered files are scanned for from getcwd() 
> downwards (iirc) - so maybe there's a way to make that configurable?

yes, that directory really should be made configurable


> i've also had a look into what's inside the sqlite file, and from my point of 
> view the structure doesn't look that complicated, imho that's nothing a 
> serialized array couldn't handle (if it really needs to be stored to disk - 
> for my case it's not even necessary).

the tests i run take about 2+ hours and sqlite helps me perform data selection
without loading the entire coverage into memory.  Having said this, all this is
handled by CoverageDataHandler and so this could have alternate implementations


> i think it would be better to integrate this deeper into the simpletest main 
> code, but that's beyond the scope of "extension", if i'm correct...

For reporting, I see someone developing some unit test reports that integrate
the coverage data, i think someone even suggested that.  I like the fact that
they can run independently, but i think there are a lot of ways folks can create
optional ways to make them work together.  

For data collection, in my situation, i run simple tests from CLI, that in turn
make http requests to a local apache server, that i need to accumulate coverage
data for.  This request knows nothing about simpletest.


On another note

I'm starting the process of using this branch for generating
 http://acquia.com/files/test-results/index.html
This is a report that is generated on a nightly basis.

Re: [Simpletest-support] Code coverage

[Marcus B. <ma...@wo...>]

Hi...

Jakob Ketterl wrote:
> i think it would be better to integrate this deeper into the simpletest main 
> code, but that's beyond the scope of "extension", if i'm correct...

Your instincts are probably right. Certainly the core will probably have
to add the appropriate hooks.

Any dependence on SQL lite would have to go for it to end up in the
core, and preferably even the file system as we cannot assume write
permissions (e.g. in cruise environments).

yours, Marcus

Re: [Simpletest-support] Code coverage

[Marcus B. <ma...@wo...>]

Hi...

Douglas Hubler wrote:
> Any progress on general review?

Sorry, been my birthday. I'm working on it as time allows.

yours, Marcus

Re: [Simpletest-support] Code coverage

[Jakob K. <jke...@ch...>]

On Tuesday 18 November 2008 06:13:16 Douglas Hubler wrote:
> Jakob Ketterl <jketterl@...> writes:
> > I found two little bugs in the reporting templates (it's just missing
> > echo statements). i'm including a patch
>
> thanks, i committed these
>
> Any progress on general review?

yes, i've even managed to integrate it with phpundercontrol (using a special 
reporter class i've hacked up myself).

however, i didn't use the concept of an external shell script to separate 
coverage setup/collection from the actual test run, and i didn't use 
autocoverage.php. this is because our code is separated from its tests, and 
simpletest itself also resides outside of the source tree. that way i can 
simply use a whitelist approach to tell cc what parts of the code it should 
generate statistics upon.

the only thing that doesn't work in that approach is the collection of 
uncovered files, so i've written a recursive function that will 
require_once() everything inside my source directories. not the best 
solution, i must admit (especially if there's executable code inside your php 
files) but it works for me atm.

i've read in the source that uncovered files are scanned for from getcwd() 
downwards (iirc) - so maybe there's a way to make that configurable?

i've also had a look into what's inside the sqlite file, and from my point of 
view the structure doesn't look that complicated, imho that's nothing a 
serialized array couldn't handle (if it really needs to be stored to disk - 
for my case it's not even necessary).

i think it would be better to integrate this deeper into the simpletest main 
code, but that's beyond the scope of "extension", if i'm correct...

Re: [Simpletest-support] Code coverage

[Douglas H. <dh...@gm...>]

Jakob Ketterl <jketterl@...> writes:
> I found two little bugs in the reporting templates (it's just missing echo 
> statements). i'm including a patch 
thanks, i committed these

Any progress on general review?

Re: [Simpletest-support] Code coverage

[Jakob K. <jke...@ch...>]

I found two little bugs in the reporting templates (it's just missing echo 
statements). i'm including a patch :-)

Re: [Simpletest-support] Code coverage

[Jakob K. <jke...@ch...>]

On Tuesday 11 November 2008 02:32:59 Douglas Hubler wrote:
> Douglas Hubler <dhubler@...> writes:
> > On ubuntu i installed this package
> >  php-sqlite3
>
> my mistake,
>   php5-sqlite
>
> is the one that i believe i'm using

actually, you didn't make a mistake there. i had already installed php5-sqlite in a guess before, but that didn't work out. i've now additionally (yes you will need both packages) installed php-sqlite3 (how big a difference a few digits can cause ;-) ) and at least i got that dependency resolved. now i'll have to move to our dev server, where xdebug is available.

i also tried to install the DB_Sqlite_Tools from pear (from channel://pear.php.net/DB_Sqlite_Tools-0.1.6) but at least it didn't work out of the box. Maybe I'll have the time to get another look...

I'm running Ubuntu 8.04.01 Hardy.

Thank you :-)