[Simpletest-devel] [ simpletest-Patches-3453485 ] Added _htmlEntities() in my_reporter.php

[SourceForge.net <no...@so...>]

Patches item #3453485, was opened at 2011-12-07 03:38
Message generated for change (Tracker Item Submitted) made by 
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=547457&aid=3453485&group_id=76550

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: https://www.google.com/accounts ()
Assigned to: Nobody/Anonymous (nobody)
Summary: Added _htmlEntities() in my_reporter.php

Initial Comment:
I found a bug, and it didn't show in the details-section of the testcase the HTML, instead the browser parsed the HTML.

So I added htmlentities(), and later is saw there's already a $this->_htmlEntities() so I used that instead.

Here my patch.

--- a/tests/simpletest/extensions/my_reporter.php
+++ b/tests/simpletest/extensions/my_reporter.php
@@ -187,7 +187,7 @@ class MyReporter extends SimpleReporter {
                        <div class="result">PASSED</div>
                        <h3>'.$test.'</h3>
                        <div class="details">
-                               <em>'.$message.'</em>
+                               <em>'.$this->_htmlEntities($message).'</em>
                        </div>
                </div>
                ';
@@ -211,7 +211,7 @@ class MyReporter extends SimpleReporter {
                        <div class="result">FAILED</div>
                        <h3>'.$test.'</h3>
                        <div class="details">
-                               <em>'.$message.'</em>
+                               <em>'.$this->_htmlEntities($message).'</em>
                        </div>
                </div>
                ';


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=547457&aid=3453485&group_id=76550