[Simpletest-devel] [ simpletest-Bugs-3002654 ] should write cookie before reading location

[SourceForge.net <no...@so...>]

Bugs item #3002654, was opened at 2010-05-17 03:57
Message generated for change (Comment added) made by pp11
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=547455&aid=3002654&group_id=76550

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Web tester
Group: None
>Status: Closed
>Resolution: Duplicate
Priority: 5
Private: No
Submitted By: makoto_kw (makoto_kw)
Assigned to: Perrick Penet (pp11)
Summary: should write cookie before reading location

Initial Comment:
In SimpleUserAgent::fetchWhileRedirected, should call writeCookiesToJar before overwriting $url by getLocation

if ($this->cookies_enabled) {
  $headers->writeCookiesToJar($this->cookie_jar, $url); // OK: store for request host
}
$location = new SimpleUrl($headers->getLocation());
$url = $location->makeAbsolute($url);
// if ($this->cookies_enabled) {
//   $headers->writeCookiesToJar($this->cookie_jar, $url); // NG: store in host redirected
//}


----------------------------------------------------------------------

>Comment By: Perrick Penet (pp11)
Date: 2011-11-30 10:34

Message:
I think this bug is a duplicate of 3385457. That one has been fixed.
Enjoy...

Yours,
     Perrick



----------------------------------------------------------------------

Comment By: Perrick Penet (pp11)
Date: 2011-04-27 09:21

Message:
Do you have a precise test case (or at least a full example) I could use
before applying your patch ? Thanks in advance.

Yours


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=547455&aid=3002654&group_id=76550