Re: [Simpletest-support] Code coverage

[Douglas H. <dh...@gm...>]

Perrick Penet <perrick@...> writes:
> First of all thank you so much for this contribution !

thanks for the review

> - there's not only a dependcy upon SQLlite but also on PEAR's DB/sqlite. 
> Could we get rid of PEAR first ?

I installed sqlite from ubuntu package. Can you give advice, on what i can do to
remove PEAR, I'm not too familiar with this.

> - there's a "test.php" file in the /coverage directory, I think it 
> should be put into /coverage/test/

sure.  

I can reword this doc too, it doesn't make this clear
http://simpletest.sourceforge.net/en/writing_extensions.html

> 
> - the /test/sample-code.php should move up one level into something like 
> /test/sample/code.php (that way we also remove the "-" in the filename, 
> "_" are used all over the place in SimpleTest code base)

sure

> 
> - while I'm at it, shouldn't we move /coverage/CoverageTemplates to 
> /coverage/templates
sure

> 
> I'll send over an other set of remarks once I have PEAR installed on my 
> machine.
thank you