|
From: Douglas H. <dh...@gm...> - 2008-11-18 21:18:49
|
(2nd post, gmane may have ate first) Jakob Ketterl <jketterl@...> writes: > On Tuesday 18 November 2008 06:13:16 Douglas Hubler wrote: > > Any progress on general review? > i didn't use the concept of an external shell script excellent, i almost didn't write shell script so folks would use the API > i've read in the source that uncovered files are scanned for from getcwd() y, we can make that configurable > i've also had a look into what's inside the sqlite file, and from my point of > view the structure doesn't look that complicated, imho that's nothing a > serialized array couldn't handle (if it really needs to be stored to disk - > for my case it's not even necessary). in my case, i generate a lot of data and sqlite helps me from loading entire coverage into memory. All of sqlite functionality is in CoverageDataHandler so it can be replaces or we can have alternate implementations no problem > i think it would be better to integrate this deeper into the simpletest main > code, but that's beyond the scope of "extension", if i'm correct... extension can know about simpletest, simpletest probably shouldn't know extension directly, however... the for report data, yes, i could see some integration there. for coverage data, although i initiate test from simpletest, web tests make http requests to my web server and i need to gather coverage data there. Nothing is known about simpletest there. |