|
From: Jakob K. <jke...@ch...> - 2008-11-18 07:26:26
|
On Tuesday 18 November 2008 06:13:16 Douglas Hubler wrote: > Jakob Ketterl <jketterl@...> writes: > > I found two little bugs in the reporting templates (it's just missing > > echo statements). i'm including a patch > > thanks, i committed these > > Any progress on general review? yes, i've even managed to integrate it with phpundercontrol (using a special reporter class i've hacked up myself). however, i didn't use the concept of an external shell script to separate coverage setup/collection from the actual test run, and i didn't use autocoverage.php. this is because our code is separated from its tests, and simpletest itself also resides outside of the source tree. that way i can simply use a whitelist approach to tell cc what parts of the code it should generate statistics upon. the only thing that doesn't work in that approach is the collection of uncovered files, so i've written a recursive function that will require_once() everything inside my source directories. not the best solution, i must admit (especially if there's executable code inside your php files) but it works for me atm. i've read in the source that uncovered files are scanned for from getcwd() downwards (iirc) - so maybe there's a way to make that configurable? i've also had a look into what's inside the sqlite file, and from my point of view the structure doesn't look that complicated, imho that's nothing a serialized array couldn't handle (if it really needs to be stored to disk - for my case it's not even necessary). i think it would be better to integrate this deeper into the simpletest main code, but that's beyond the scope of "extension", if i'm correct... |