Re: [sigrok-devel] [PATCH v2] jtag: fix DR/IR shifting from TDI

[Uwe H. <uw...@he...>]

Hi,

On Mon, Apr 16, 2018 at 04:49:44PM +0300, Vlad Ivanov wrote:
> https://gitlab.com/LabSystems/libsigrokdecode/commit/17eef9c7aa959ec4dabd9edddd2b4275060eef9a

Thanks!

I had another closer look at the patch and the ones from #1066 as well.
As far as I can tell it's indeed a bug in both jtag and jtag_stm32, the
off-by-one issue in jtag_stm32 was a "hack" workaround.

I've decided to merge the patches from #1066 after all, those are
slightly more complex, but more correct as well, IMHO. The annotations
are now fixed to start and stop at the correct (new) state changes etc.,
see attached screenshot.

Please check the current PD in mainline, and let us know if there are
any additional issues which might still need fixing maybe. Thanks!


Cheers, Uwe.
-- 
http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org