Re: [sigrok-devel] FTDI FT80x and FT81x proposal

[Uwe H. <uw...@he...>]

Hi,

On Mon, Apr 23, 2018 at 09:30:54AM +0200, Lorenzo Cappelletti wrote:
> The only "problem" I could think of was that someone else might be
> working on the same chip.

We're not aware of anyone working on such a PD, please continue :)

 
> I didn't ask. I assume there is no IP since the protocol is well
> documented on the chip datasheet and a few more documents freely
> downloadable from manufacturer web site. Should I ask for permission?

No need to ask anyone. If you wrote the code (and didn't copy someone
else's code or such) you own the copyright and if you add the usual
license header etc. everything is fine.

 
> You can have a look at https://github.com/lorcap/libsigrokdecode

Looks good so far. Small cosmetics: Please don't overdo it with the
tabular "alignment" thingies like these:

+    def host_memory_read (addr):
+        return [Ann.TRANSACTION,
+                ['Host Memory Read: 0x%06X' % addr,
+                 'Read: %06X' % addr,
+                 'Read',
+                 'R']]

+    annotation_rows = (
+        ('transaction', 'Transaction', (Ann.TRANSACTION, )),
+        ('write'      , 'Write'      , (Ann.CMD        ,
+                                        Ann.DUMMY      ,
+                                        Ann.PARAM      ,
+                                        Ann.READ_ADDR  ,
+                                        Ann.WRITE_ADDR ,
+                                        Ann.WRITE_DATA , )),
+        ('read'       , 'Read'       , (Ann.READ_DATA  , )),
+    )

We almost always try to avoid those, just use a compact representation (also
in order to be consistent with the rest of the decoders), e.g.

+    def host_memory_read (addr):
+        return [Ann.TRANSACTION, ['Host Memory Read: 0x%06X' % addr,
+                'Read: %06X' % addr, 'Read', 'R']]

+    annotation_rows = (
+        ('transaction', 'Transaction', (Ann.TRANSACTION,)),
+        ('write', 'Write', (Ann.CMD, Ann.DUMMY, Ann.PARAM, Ann.READ_ADDR,
+                            Ann.WRITE_ADDR, Ann.WRITE_DATA,)),
+        ('read', 'Read', (Ann.READ_DATA,)),
+    )


Cheers, Uwe.
-- 
http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org