From: Aurelien J. <au...@gn...> - 2014-02-06 00:02:53
|
On Wed, Feb 05, 2014 at 02:29:27PM +0100, Damir Jelić wrote: > On Tue, Feb 04, 2014 at 11:45:24PM +0100, Aurelien Jacobs wrote: > > --- > > hardware/hameg-hmo/api.c | 206 +---------------------------------------------- > > 1 file changed, 2 insertions(+), 204 deletions(-) > > > > diff --git a/hardware/hameg-hmo/api.c b/hardware/hameg-hmo/api.c > > index 5abd8c5..241e86b 100644 > > --- a/hardware/hameg-hmo/api.c > > +++ b/hardware/hameg-hmo/api.c > > @@ -18,7 +18,6 @@ > > */ > > > > #include <stdlib.h> > > -#include <glib/gstdio.h> > > #include "protocol.h" > > > > #define SERIALCOMM "115200/8n1/flow=1" > > Here is the default SERIALCOMM parameter that I mentioned already. > > [...] > > How to fix this? You could pass the default options to scpi_scan() or > you could pair them with the USB VID/PID. Pairing them with the USB VID/PID sounds like the best option to me. This way, if someday we manage to write a generic scpi-scope driver, it won't need to know if it is talking to a rigol through usbtmc or to a hameg through a HO730 serial interface. The serialcomm is associated with the serial interface itself, not with the scope driver. So I implemented this. Fixed patchset is available here: https://github.com/aurelj/libsigrok/commits/scpi If you want me to post it on the mailing list again, just tell me. > Despite of this small issue I think this is really great work Thanks. > it moves us closer to having common driver/scpi boiler plate > separated from the drivers. That was the goal :-) Aurel |