#29 Broken ADSR and 8580 filter with 2.0

[Max Beck]

After upgrading to sidplay 2.0, I have noticed that the 8580 filter is now emulated incorrectly - far too dark and distorted, and the ADSR also is broken - it seems to try way too hard to emulate the ADSR bug, causing notes that are otherwise fine on real hardware to sustain forever. The filter issues can be mostly resolved by tweaking around with the filter curve and enabling digiboost, but it's still not quite correct, and it's definitely more of a hack than a real fix. This tune demonstrates both issues, and I have attached both a recording from sidplayfp 2.0 with default config and from real hardware (ripped from this video).

[Leandro Nini]

Thanks for the report. The filter issue is already known and reported at [vice-emu:bugs:#909]
Will check the ADSR problem, have you checked both resid and residfp engines?

[Max Beck]

Yeah, resid does not have the issue. Here's a couple more songs that also demonstrate it:

https://csdb.dk/release/?id=180555
https://csdb.dk/sid/?id=56663
https://csdb.dk/sid/?id=56521 (this one only has the issue in one small section, around 0:55)
https://csdb.dk/sid/?id=55916

[Leandro Nini]

ADSR bug fixed in trunk at r2629

[Leandro Nini]

filter improved at r2632

[Max Beck]

Sounds much better now! Hopefully a fix for the filter besides radiant's hack can be found, but it sounds perfect to my ears.

[Leandro Nini]

Great, thank you!

[Leandro Nini]

Fixed in libsidplayfp-2.0.1