#19 Some sids don't play correctly.

[Jesper Hansen]

The current version (r2508) can't play some sids that plays fine with 1.8.7.

Some of them are (from HVSC 67):

DEMOS/A-F/BeepSync.sid (silent)
DEMOS/A-F/Christmas_Music.sid (just a low rumbling)
DEMOS/M-R/Reveko.sid (silent)
DEMOS/UNKNOWN/Morning_has_Broken.sid (silent)
GAMES/A-F/Alcatraz.sid (only play the first node)

If needed, I can properly find a few more sid that have the similar problems.

The output from sidplayfp does not say much, but here it is:

+------------------------------------------------------+
|  SIDPLAYFP - Music Player and C64 SID Chip Emulator  |
|    Sidplayfp V2.0.0beta, Libsidplayfp V2.0.0beta     |
+------------------------------------------------------+
| Title        : BeepSync                              |
| Author       : Niels van Dijkhuizen (NebulaH)        |
| Released     : 2011 NebulaH                          |
+------------------------------------------------------+
| File format  : PlaySID one-file format (PSID)        |
| Filename(s)  : BeepSync.sid                          |
| Condition    : No errors                             |
| Playlist     : 1/1 (tune 1/1[1])                     |
| Song Speed   : 50 Hz VBI (PAL)                       |
| Song Length  : UNKNOWN                               |
+------------------------------------------------------+
| Addresses    : DRIVER = $0400-$04FF, INIT = $1000    |
|              : LOAD   = $1000-$1FF8, PLAY = $1003    |
| SID Details  : Filter = Yes, Model = 8580            |
+------------------------------------------------------+
| Kernal ROM   : C64 KERNAL third revision             |
| BASIC ROM    : C64 BASIC V2                          |
| Chargen ROM  : C64 character generator               |
+------------------------------------------------------+

[Leandro Nini]

Checked with iAN CooG/HVSC, these are all broken rips and will be fixed in the next HVSC release. Feel free to report any other non working tune.

[Jesper Hansen]

Here are some more sids that no longer plays:

All of them, except Iron_Horse.sid, only have one song.

GAMES/A-F/Alcatraz.sid
GAMES/A-F/Blakhole.sid
MUSICIANS/B/Bjerregaard_Johannes/Cant_Stop.sid
MUSICIANS/B/Bjerregaard_Johannes/Chase_v2.sid
MUSICIANS/B/Bjerregaard_Johannes/DMC_Demo_IV_tune_2.sid
MUSICIANS/B/Bjerregaard_Johannes/DMC_Demo_IV_tune_3.sid
MUSICIANS/B/Bjerregaard_Johannes/DMC_Demo_IV_tune_5.sid
MUSICIANS/B/Bjerregaard_Johannes/Fourth_Dimension.sid
MUSICIANS/B/Bjerregaard_Johannes/Hit_the_Baze.sid
MUSICIANS/B/Bjerregaard_Johannes/Namnam_Special.sid
MUSICIANS/B/Bjerregaard_Johannes/Rockbuster.sid
MUSICIANS/B/Bjerregaard_Johannes/Rosanna.sid
MUSICIANS/B/Bjerregaard_Johannes/Tiny_Symphony.sid
MUSICIANS/B/Blues_Muz/Gallefoss_Glenn/Faeries.sid
MUSICIANS/C/Cane/Liberator_2.sid
MUSICIANS/C/Cannon_Matthew/Parallax_Rip-Off.sid
MUSICIANS/C/Chubrock/Desert_intro.sid
MUSICIANS/C/Chubrock/Romantic.sid
MUSICIANS/C/Chubrock/Smilygirl.sid
MUSICIANS/D/Deenen_Charles/Say_Hello_to_the_Boring_Times.sid
MUSICIANS/D/Deenen_Charles/Worktunes/Rambo_2.sid
MUSICIANS/D/Defbeat/Christmas_1989_tune_2.sid
MUSICIANS/D/Drumbeat/Contact_Us.sid
MUSICIANS/D/Drumbeat/For_Mithrandir.sid
MUSICIANS/D/Dunn_Jonathan/Bart_vs_The_Space_Mutants.sid
MUSICIANS/E/Eclipse/Ambition.sid
MUSICIANS/E/Eclipse/Sadness.sid
MUSICIANS/F/Falciparum/Meet_the_Friends.sid
MUSICIANS/F/FieserWolF/Sarotti_Milka.sid
MUSICIANS/F/FieserWolF/Stormy_City.sid
MUSICIANS/F/Fredrik/Forest.sid
MUSICIANS/F/Fredrik/Kalles_Klaettertraed.sid
MUSICIANS/F/Fredrik/Saxophone.sid
MUSICIANS/G/Glover/Worktunes/Sosperec_Test.sid
MUSICIANS/J/Jazzman/Bluesbox.sid
MUSICIANS/L/Lead/Paradise.sid
MUSICIANS/L/Leitch_Barry/Stratego.sid
MUSICIANS/M/Mad_Donne_Marcel/Hollander.sid
MUSICIANS/M/Magnar/Five_Hours.sid
MUSICIANS/M/Magnar/We_Are_New_tune_1.sid
MUSICIANS/M/Marcy/Marcy_03.sid
MUSICIANS/O/Odo/1000.sid
MUSICIANS/O/Odo/Swinks.sid
MUSICIANS/P/Peet/Higher_Love_tune_4.sid
MUSICIANS/P/Peet/Revolution_end.sid
MUSICIANS/P/Peet/Revolution_plotter.sid
MUSICIANS/P/Phobos/On_Grabowsky.sid
MUSICIANS/S/Sentinel_Cherubs/Strange_Girl.sid
MUSICIANS/S/Siebold_Markus/Flexible_Zone.sid
MUSICIANS/S/Stainless_Steel/Division_by_Zero.sid
MUSICIANS/S/Stainless_Steel/Praise_You.sid
MUSICIANS/S/Stainless_Steel/So-Phisticated_III_part_1.sid
MUSICIANS/S/Surgeon/One_Life.sid
MUSICIANS/T/TDS/A_Gift.sid
MUSICIANS/T/TDS/LCP_8580.sid
MUSICIANS/T/TDS/Trapped_Into_Circles.sid
MUSICIANS/T/Thorne_Jeremy/Song_Writer-Follow_Me.sid
MUSICIANS/T/Thorne_Jeremy/Song_Writer-Games.sid
MUSICIANS/T/Thorne_Jeremy/Song_Writer-Life.sid
MUSICIANS/T/Thorne_Jeremy/Song_Writer-Lost.sid
MUSICIANS/T/Thorne_Jeremy/Song_Writer-Mind_Over_Matter.sid
MUSICIANS/T/Thorne_Jeremy/Song_Writer-REM10.sid
MUSICIANS/T/Thorne_Jeremy/Song_Writer-Tell_Me.sid
MUSICIANS/T/Trays/Justincase_note.sid
MUSICIANS/T/Trays/Promethida_note.sid
MUSICIANS/T/Trays/Promethida_part_2.sid
MUSICIANS/T/Trays/Promethida_part_5.sid
MUSICIANS/T/Trays/Promethida_part_7.sid
MUSICIANS/T/Trays/Promethida_part_8.sid
MUSICIANS/T/Trays/Promethida_part_9.sid
MUSICIANS/U/Ultrasyd/Havskatt.sid
MUSICIANS/U/Ultrasyd/Syltetoey.sid
MUSICIANS/V/V-12/Remember.sid
MUSICIANS/W/Whittaker_David/Iron_Horse.sid
MUSICIANS/W/Wilson_Mark/Augie_Doggie_and_Doggie_Daddy.sid

[iAN_CooG]

Thanks for the report, most of these tunes lacked a proper LDX #$00 (and most of them just need a TAX before init, being A already loaded with 0 on init for single tunes) and are fixed for next HVSC update.
Most sid players zero all 3 regs and then load A with subtune number, before calling init, so they went unnoticed for years, but the problem is known and my automatic ripping tool prg2sid was made also to apply these patches where needed. Other times it's just a matter of adding manually an AA opcode with an hexeditor.

I don't know what happens with these:

/MUSICIANS/J/Jazzman/Bluesbox.sid
Hum, this probably should be RSID and not PSID, it starts with SEI and never exits the interrupts-disabled state. I have to examine it further.

/MUSICIANS/L/Lead/Paradise.sid
I have to investigate the IRQ init in this, probably it's not set enough correctly, but it plays almost everywhere

/MUSICIANS/S/Surgeon/One_Life.sid
This is a normal DMC 4.x tune, init is proper and doesn't need anything than A loaded with 0, plays everywhere with no problems. Diagnostic tools don't find any reading of unitialized memory outside load range or execution of bad instructions or BRK.

/MUSICIANS/T/Thorne_Jeremy/Song_Writer_etc.sid
These are almost fixed, I have to experiment more later. They are closed loops, not using IRQ or CIA timing at all, so the kernal routines which update the $a2 timer in ZP is never updated. I've installed a dummy IRQ handler in init, and also found a possible BRK execution when the end of tune pointer (loc. $FB contains $FF, code at $0ac1) is reached, which can be replaced with a forced reinit to loop.

iAN CooG/HVSC

[Leandro Nini]

reopening until everything is sorted out

[Leandro Nini]

As for /MUSICIANS/S/Surgeon/One_Life.sid it's ok, just a problem with the filter emulation (see [bugs:#20])

[iAN_CooG]

/MUSICIANS/J/Jazzman/Bluesbox.sid
confirmed working as RSID
/MUSICIANS/T/Thorne_Jeremy/Song_Writer_etc.sid
all fixed and working

Still no idea what's wrong with
/MUSICIANS/L/Lead/Paradise.sid
I think you have to investigate further yourself about it.

[Leandro Nini]

Tracked down the offending commit that broke /MUSICIANS/L/Lead/Paradise.sid: [r1853]
Now looking for a fix...

[Leandro Nini]

/MUSICIANS/L/Lead/Paradise.sid fixed in trunk [r2595] by restoring power on delay