Menu

fix for lispworks

Gorbag
2013-04-29
2013-05-20
  • Gorbag

    Gorbag - 2013-04-29

    Everything seems to compile fine (is there a regression test?) once the following patch is made in file shop-asd.asd

    (defpackage :shop2-asd
        (:use :common-lisp :asdf)
        (:shadow #:defconstant)
        #+(or allegro sbcl ccl clisp hcl) ; add hcl 4/29/13 BWM
        (:import-from #+allegro aclmop     #+sbcl sb-mop
                      #+ccl ccl #+clisp clos #+lispworks hcl
                      #:class-direct-superclasses)
        #-(or allegro sbcl ccl clisp lispworks)
        (error "Don't know how to find CLASS-DIRECT-SUPERCLASSES in this lisp.")
        )

     
  • Gorbag

    Gorbag - 2013-04-29

    Sorry, the first occurrence of 'hcl' should be 'lispworks' (the feature) - cut/paste the wrong version.

    (defpackage :shop2-asd
        (:use :common-lisp :asdf)
        (:shadow #:defconstant)
        #+(or allegro sbcl ccl clisp lispworks) ; add hcl 4/29/13 BWM
        (:import-from #+allegro aclmop     #+sbcl sb-mop
                      #+ccl ccl #+clisp clos #+lispworks hcl
                      #:class-direct-superclasses)
        #-(or allegro sbcl ccl clisp lispworks)
        (error "Don't know how to find CLASS-DIRECT-SUPERCLASSES in this lisp.")
        )

     
  • Gorbag

    Gorbag - 2013-05-01

    patch to shop2.lisp - for gc

    in function find-plans:

      #+(or :ccl :allegro :sbcl clisp lispworks)
      (when gc #+allegro (excl:gc t)
            #+sbcl (sb-ext:gc)
            #+ccl (ccl:gc)
            #+clisp (ext:gc)
            #+lispworks (hcl:gc-generation t)) ; add case for lispworks 5/1/13 BWM
      #-(or :cCL :allegro :sbcl clisp lispworks)

     
  • Gorbag

    Gorbag - 2013-05-01

    patch to fiveam-asdf file code.lisp

    In function perform:

              (error 'fiveam-test-fail :failed-asdf-component sys :failed failures)))))) ;; failed instead of results BWM 5/1/13

     
  • Robert P. Goldman

    Thanks for these.  I'm pushing the first two in, and they will appear in a future version 2.9.1.  Unfortunately, I can't actually test on lispworks.

    As for the test fail, I need to check on how this will work - FiveAM has drifted, and we haven't pulled our local version together with upstream in a while.

     
  • Robert P. Goldman

    Oh, yes, sorry, I see.  That was simply a typo.  Will fix that, too.  Many thanks!

     
  • Gorbag

    Gorbag - 2013-05-01

    Results of regression test suite (do not take this as a benchmark; I was running other processes).

    MacOS X 10.8.3
    Lispworks Enterprise Mac (64-bit) 6.1.1

    CL-USER 10 > (time (asdf:oos 'asdf:test-op :shop2))
    Timing the evaluation of (ASDF:OOS (QUOTE ASDF:TEST-OP) :SHOP2)

    Defining domain QUANTIFIED-WHEN-DOMAIN…
    ……
    Defining domain TEST-ADD-DEL-DOMAIN…
    ……
    Defining domain DOMAIN0…
    .
    Warning: Redefining domain named #<DOMAIN ARITY-TEST-DOMAIN>……
    Defining domain QUANTIFIED-PRECONDITIONS-DOMAIN…
    ….
    Defining domain PROTECTION-TEST-DOMAIN…
    ……………….
    Defining domain SIMPLE-WHEN-DOMAIN…
    ..
    Defining domain PROTECTION-TEST-DOMAIN…
    …………….
    Warning: Redefining domain named #<DOMAIN ARITY-TEST-DOMAIN>……………………………………………………………………………………………………………………….
    Did 196 checks.
        Pass: 196 (100%)
        Skip: 0 ( 0%)
        Fail: 0 ( 0%)

    User time    =  0:15:07.401
    System time  =       11.994
    Elapsed time =  0:15:12.272
    Allocation   = 59213817320 bytes
    4303606 Page faults
    Calls to %EVAL    4028
    NIL

    CL-USER 11 >

     
  • Gorbag

    Gorbag - 2013-05-01

    @rpgoldman

    I'm happy to test on lispworks for you (see above). Also note that there is a FREE 'personal' version:

    http://www.lispworks.com/downloads/index.html

    The main limitations is that it will exit after some number of hours and not load patches or an init file.  (you can manually load an init file).

    Available for a variety of platforms.

    Best,
    Brad Miller

     
  • Robert P. Goldman

    Thanks, Brad.  I have tried to use the Lispworks personal version, but I doubt it will work for this purpose.  Some of the tests need a fair number of cycles and memory, and I believe that LW personal is limited that way.  Also, I can't run it in a shell, which makes testing painful…

     

Log in to post a comment.