Re: [Shinken-devel] livestatus + test_livestatus
Status: Beta
Brought to you by:
naparuba
From: Grégory S. <g.s...@gm...> - 2011-02-17 19:52:51
|
2011/2/17 nap <nap...@gm...> > > > 2011/2/17 Grégory Starck <g.s...@gm...> > >> [...] >> >> well, finally I got the whole thing ok (test_livestatus included) : (but) >> for this I had "simply" to use a copy.deepcopy at livestatus level .. but >> now with this fix I have all features ok with Thruk for comments & >> downtimes ; and the tests normally still are ok too :) >> >> don't know if this would be acceptable to you ?? because now for >> manage_brok we'll have a copy of the brok every time be done.. not sure >> it's acceptable from a performance point of view, wdty ? >> > Is the copy in the module code or in the test_livestatus one? > in the basemodule :s well so I guess this needs a bit more think still .. or not.. in fact ; I don't see clearly why the manage_brok method of the modules needs to always have a brok where the main object concerned is transformed into a dict in the brok.data field/attribute.. for livestatus at least but possibly for all modules.. I'm afraid I'm a bit lost with what is "serialized" (for transport between (eventually "remote") processes) / when / how / why .. greg. > If it's just in the test it's not a problem, but it can be if it's in the > module. If it is in the module code, just put a deepcopy in update_brok in > test_livestatus code, so even Downtime nested in the dict will be duplicated > without problem. > > > > Jean > > >> >> greg. >> >> >> > > > ------------------------------------------------------------------------------ > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > _______________________________________________ > Shinken-devel mailing list > Shi...@li... > https://lists.sourceforge.net/lists/listinfo/shinken-devel > > |