Menu

#1361 Files added to encrypted archive are not encrypted

open
nobody
None
4
2018-09-04
2013-04-17
fresheneesz
No

On windows 7-Zip 9.20, 7z archives encrypted with the "Encrypt file names" option will revert to not encrypting file names when a file or folder is added to the archive. This does not happen when files are changed or deleted.

Discussion

  • fresheneesz

    fresheneesz - 2013-04-17

    Also, the file added to the archive is not encrypted - which makes it incredibly annoying to handle encrypted folders. I would have to extract the whole archive and reencrypt it every time I add a file.

     
  • fresheneesz

    fresheneesz - 2013-04-17

    Looks like this is a duplicate of https://sourceforge.net/p/sevenzip/bugs/1350/

     
  • jorel009

    jorel009 - 2013-07-22

    Ok this is a deal breaker from a security stand point. i cant believe this is not fixed yet. i am going to have to look at other solutions.

     
  • Mikey

    Mikey - 2013-08-13

    I just posted a comment in this discussion https://sourceforge.net/p/sevenzip/discussion/45797/thread/0b918e30/#25f3 that I found on google that is related to this. This problem was originally found in November 2010 and it looks like it's being ignored or the developers don't think it's a bug and won't fix it.

     
  • fresheneesz

    fresheneesz - 2013-08-13

    That is super lame, but it looks like the OP didn't properly explain the bug, which caused a helluva lota confusion. Looks like:

    1. Its not broken if you do it through the context menu (right click -> add to archive ... -> select an already created archive -> press ok -> type in the password (already created on the archive)

    2. It is broken if you open an archive -> type in its password -> then drag a file into the archive.

     
  • fresheneesz

    fresheneesz - 2014-09-23

    Why hasn't this been looked into? This is a huge problem for both people who don't know about it, and for people like me that always forget about it.

     
  • fresheneesz

    fresheneesz - 2014-09-26

    Forked the repo and working on this bug: https://github.com/fresheneesz/7zip2

     
  • Igor Pavlov

    Igor Pavlov - 2014-09-26

    Did you check the problem in 7-Zip 9.34 alpha?

     
    • Wuller D. Wust

      Wuller D. Wust - 2014-10-07

      I tried 9.34 alpha, and the problem is not fixed.

       
      • Igor Pavlov

        Igor Pavlov - 2014-10-07

        Please describe all steps in your test in 9.34.

         
        • Wuller D. Wust

          Wuller D. Wust - 2014-10-07

          Hi Igor. First I create a password-protected, file-name encrypted .7z archive. Then I open the archive. I add a new text file to the archive using drag-and-drop. The new file is not encrypted, however the archive and existing files remain encrypted.

           
  • fresheneesz

    fresheneesz - 2014-09-26

    I built from the source available on sourceforge and it still exists - I assume that is up to date. The problem has been around for at least 4 years. Do you acknowledge this is an issue Igor? Here is what I think the behavior should be exactly when someone drags a file into an archive

    Condition: If the archive has its filenames encrypted
    Behavior: After adding the drag-and-dropped file to the archive, the archive should still have filenames encrypted (which I believe implicitly means the added file will be protected with encryption as well). No "Confirm File Copy" dialog should appear - it should just do it.

    Condition: If the archive does not have filenames encrypted, but does have encryption on all files in the archive
    Behavior: The drag-and-dropped file should be added with the same encryption as other files in the archive. Again, no "Confirm File Copy" dialog should appear.

    Condition: If only some of the files in the archive are encrypted
    Behavior: Instead of the "Confirm File Copy" dialog, a dialog asking the user "Encrypt file" or "Don't Encrypt". If the user chooses "Encrypt", the file should be encrypted in the same way other files are encrypted in the archive. If the user chooses "Don't Encrypt" add the file without encryption.

    Does this make sense to you Igor?

     
  • Mikey

    Mikey - 2015-01-05

    The problem I described above is now fixed. Thank you very much. I am thrilled to start using 7zip now and will likely make a donation soon.

     
  • sf221sf221

    sf221sf221 - 2018-03-15

    I don't really follow Mikey's issue as he linked above. It looks to be related to additional software and off topic. The bug that is the subject of this ticket was not fixed as 2015-01-05 (version 9.38). We just had a data security breach due to the silent decryption of filenames by the GUI when updating an archive. I've discovered that encrypted archives seemed to be properly handled in version 18.03, but don't know when this was fixed since I see mention of it in the version history and these tickets remain open.

     

    Last edit: sf221sf221 2018-03-16
  • Uli Wischnath

    Uli Wischnath - 2018-09-04

    Hi, just to add on to this: When copying an encryted file from one zip-archive into another one, in which all the files are encryted as well, the copied file is not encrypted. My only workaround is very tedious: first copy the file to a normal folder and thereafter add it via the 7-zip context menu to the destination archive. It would help already if I could at least encrypt a file that I have copied to an archive. Is there a possibility to do this subsequently? I looked out for this in many places but can't find it. Can someone help?

    And as the task of copying files and encryption has been discussed for so long: Please consider it for the next release! Thank you.

     

Log in to post a comment.

MongoDB Logo MongoDB