Re: [seq24-users] mute groups feature - first impressions... AND code patch for --show_keys to work....

[Guido S. <gui...@ba...>]

Am Fri, 24. Apr 2009 um 11:06:54 -0500 schrieb Kevin Meinert:

Hi kevin,

[Mute group feature]

> anyway, on the train this morning, I added in code to let the user know that
> their mapping attempt failed because the key is already bound to a
> [keyboard-sequencer] item...     it makes a lot more sense now, UI-wise...
> rather than the "learn" action failing silently.
> 
> I'll try to polish it up a bit and will send the code this weekend.
> I may try some things with doing a learn mode for the sequencer keys also...
> maybe a "learn" button on the main UI too...  i don't know how far i'll
> get...

this patch is also applied now, but there are some issues to be solved;
so it has some kind of preliminary state. Sorry I have no time to care
for it my self, just preparing for a holiday journey.

1) perform.cpp: Magic numbers for keys used in set_key_group() must be
   replaced by names like defined in

   /usr/include/gtk-2.0/gdk/gdkkeysyms.h


2) seq24.cpp: The key2text() function most probably can/should be replaced
   by a more generic approach "gdk_keyval_name()", see

  http://library.gnome.org/devel/gdk/stable/gdk-Keyboard-Handling.html

  This may also have advantages for key name backward translation.


3) The design of the "keyboard" tab in the options dialog is kind of
   crude and should be redesigned at least using layout management
   (and some more user friendly optimizations).

Not to forget: Great work Kevin and N.N., thanks a lot.

Guido

-- 
http://www.bayernline.de/~gscholz/
http://www.lug-burghausen.org/