Re: [seq24-users] : apply patch to the svn version

[Kevin M. <ke...@su...>]

>> good luck.   maybe Guido can help with the configure file?

and with this, I don't mean to shove the work off onto you or others, but
this is the point where I need to ask for some help, as I don't have the
ability to compile under linux with this.     I really appreciate your
effort to clear up the linux compile!   :-)

thanks again,
---
kevin meinert | http://www.subatomicglue.com


On Wed, May 20, 2009 at 9:12 PM, Kevin Meinert <ke...@su...>wrote:

>
> Hi Frank,
>
> This:
> #ifdef PTHREAD_SUPPORT
>
> and this:
> #endif
>
> are the only changes to the mutex.h file (mutex.cpp didn't change)
>
> more than likely PTHREAD_SUPPORT is not being defined by the build system
> (by make, or by configure)...
> possibly 1.) PTHREAD_SUPPORT needs to be added to the configure script, or
> 2.) you didn't turn it on with some option in configure..
>
>
> NOTE: i'm just guessing, I don't use the configure script on win32...
>
> good luck.   maybe Guido can help with the configure file?
>
>
> ---
> kevin meinert | http://www.subatomicglue.com
>
>
> On Wed, May 20, 2009 at 11:41 AM, Frank Kober <goe...@ya...> wrote:
>
>>
>> Replacing midibus.cpp by the original does work. The next error is:
>>
>> mutex.cpp:24: error: ‘const pthread_mutex_t mutex::recmutex’ is not a
>> static member of ‘class mutex’
>> mutex.cpp:25: error: ‘const pthread_cond_t condition_var::cond’ is not a
>> static member of ‘class condition_var’
>> mutex.cpp: In constructor ‘mutex::mutex()’:
>> mutex.cpp:29: error: ‘m_mutex_lock’ was not declared in this scope
>> mutex.cpp:29: error: ‘recmutex’ was not declared in this scope
>> mutex.cpp: In member function ‘void mutex::lock()’:
>> mutex.cpp:35: error: ‘m_mutex_lock’ was not declared in this scope
>> mutex.cpp: In member function ‘void mutex::unlock()’:
>> mutex.cpp:42: error: ‘m_mutex_lock’ was not declared in this scope
>> mutex.cpp: In constructor ‘condition_var::condition_var()’:
>> mutex.cpp:47: error: ‘m_cond’ was not declared in this scope
>> mutex.cpp:47: error: ‘cond’ was not declared in this scope
>> mutex.cpp: In member function ‘void condition_var::signal()’:
>> mutex.cpp:54: error: ‘m_cond’ was not declared in this scope
>> mutex.cpp: In member function ‘void condition_var::wait()’:
>> mutex.cpp:60: error: ‘m_cond’ was not declared in this scope
>> mutex.cpp:60: error: ‘m_mutex_lock’ was not declared in this scope
>> make[2]: *** [mutex.o] Error 1
>>
>> Is this file in the same category, i.e. to replace by the original?
>>
>> Thanks
>> Frank
>>
>>
>> --- En date de : Mer 20.5.09, Kevin Meinert <ke...@su...> a
>> écrit :
>>
>> > De: Kevin Meinert <ke...@su...>
>> > Objet: Re: [seq24-users] : apply patch to the svn version
>> > À: "Frank Kober" <goe...@ya...>
>> > Cc: "Mysth-R" <mys...@gm...>, seq...@li...
>> > Date: Mercredi 20 Mai 2009, 15h59
>> > >> also, I do not compile
>> > midibus.cpp on linux,
>> >
>> > that should read _win32_... :)    i use
>> > midibus-portaudio.cpp on win32...   midibus.cpp is for
>> > non-win32...
>> >
>> > ---
>> > kevin meinert | http://www.subatomicglue.com
>> >
>> >
>> >
>> >
>> > On Wed, May 20, 2009 at 8:59 AM,
>> > Kevin Meinert <ke...@su...>
>> > wrote:
>> >
>> >
>> > win32 version does not use configure, (see config-win32.h,
>> > which you simply copy over config.h when compiling on win32)
>> > so the configure method should still work for linux (i.e.
>> > nothing is changed there)...
>> >
>> > also, I do not compile midibus.cpp on linux, I believe
>> > it's midibus-portaudio.cpp, ....   the changes you see
>> > in midibus.cpp/h are from rob's "0.8.7 win32
>> > beta1" source code...   so it's possible it was
>> > broken.   maybe try reverting just those 2 files...
>> >
>> >
>> >
>> >
>> >
>> > ---
>> > kevin meinert | http://www.subatomicglue.com
>> >
>> >
>> >
>> > On Wed, May 20, 2009 at 1:48 AM, Frank
>> > Kober <goe...@ya...>
>> > wrote:
>> >
>> >
>> >
>> >
>> > Hi Kevin,
>> >
>> > I had the same error as Mysth-R yesterday applying all
>> > patches in that order. Now with your latest patch update,
>> > I'm getting the following lines below.
>> >
>> > I blindly guessed that this could be related to flags being
>> > set or not (win32/linux). I'm using Linux as well, so do
>> > I have to enforce ALSA-usage at configure time or should
>> > this be done automatically? If not how can I properly
>> > ./configure for linux/alsa/jack ?
>> >
>> >
>> >
>> >
>> >
>> > Thanks in advance, it's moving forward ;)
>> >
>> > Frank
>> >
>> >
>> >
>> >
>> >
>> > midibus.cpp:95: error: prototype for
>> > ‘midibus::midibus(char, int)’ does not match any in
>> > class ‘midibus’
>> >
>> > midibus.h:56: error: candidates are: midibus::midibus(const
>> > midibus&)
>> >
>> > midibus.h:56: error:
>> > midibus::midibus()
>> >
>> > midibus.cpp: In constructor
>> > ‘mastermidibus::mastermidibus()’:
>> >
>> > midibus.cpp:910: error: ‘m_alsa_seq’ was not declared
>> > in this scope
>> >
>> > midibus.cpp:910: error: ‘snd_seq_client_id’ was not
>> > declared in this scope
>> >
>> > midibus.cpp:877: warning: unused variable ‘ret’
>> >
>> > midibus.cpp: In member function ‘std::string
>> > mastermidibus::get_midi_out_bus_name(int)’:
>> >
>> > midibus.cpp:1239: error: ‘class midibus’ has no member
>> > named ‘get_client’
>> >
>> > midibus.cpp:1240: error: ‘class midibus’ has no member
>> > named ‘get_port’
>> >
>> > midibus.cpp: In member function ‘std::string
>> > mastermidibus::get_midi_in_bus_name(int)’:
>> >
>> > midibus.cpp:1265: error: ‘class midibus’ has no member
>> > named ‘get_client’
>> >
>> > midibus.cpp:1266: error: ‘class midibus’ has no member
>> > named ‘get_port’
>> >
>> > make[2]: *** [midibus.o] Error 1
>> >
>> > make[2]: Leaving directory `/home/fkhome/seq24/src'
>> >
>> > make[1]: *** [all] Error 2
>> >
>> > make[1]: Leaving directory `/home/fkhome/seq24/src'
>> >
>> > make: *** [all-recursive] Error 1
>> >
>> >
>> >
>> >
>> >
>> > --- En date de : Mer 20.5.09, Kevin Meinert <ke...@su...>
>> > a écrit :
>> >
>> >
>> >
>> > > De: Kevin Meinert <ke...@su...>
>> >
>> > > Objet: Re: [seq24-users] : apply patch to the svn
>> > version
>> >
>> > > À: "Mysth-R" <mys...@gm...>
>> >
>> > > Cc: seq...@li...
>> >
>> > > Date: Mercredi 20 Mai 2009, 1h05
>> >
>> > >
>> >
>> > > Yep, when I fixed that bug, I forgot to update the
>> > patch,
>> >
>> > > while the fix was in source
>> >
>> > > code tarball
>> >
>> > >
>> >
>> > > The patch is now updated (which I visually verified
>> > just
>> >
>> > > now...)
>> >
>> > >
>> >
>> > > should be updated now, let me know how it works.
>> >
>> > >
>> >
>> > > ---
>> >
>> > > kevin meinert | http://www.subatomicglue.com
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > On Tue, May 19, 2009 at 4:37 PM,
>> >
>> > > Kevin Meinert <ke...@su...>
>> >
>> > > wrote:
>> >
>> > >
>> >
>> > >
>> >
>> > > for the time being, move that code to public (or put
>> >
>> > > public: keyword before it)  to get past the
>> > error.   I
>> >
>> > > will take a look tonight.   this reminds me of
>> > something I
>> >
>> > > fixed already, so possibly I grabbed a slightly older
>> > diff
>> >
>> > > by mistake...   I will check it out.
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > what I think is probably wrong...
>> >
>> > > There should be a member in class perform that
>> > accesses
>> >
>> > > that variable (search for the variable in perform.h)
>> > and
>> >
>> > > users of that variable should use that accessor
>> > method
>> >
>> > > rather than access the private data variable
>> > directly.
>> >
>> > > unless it's the options class, in which case,
>> > options
>> >
>> > > should be a friend of that class (add a friend class
>> >
>> > > options; to the bottom of perform class)...
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > anyway, i'll follow up tonight...
>> >
>> > > ---
>> >
>> > > kevin meinert | http://www.subatomicglue.com
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > On Tue, May 19, 2009 at 4:17 PM, Mysth-R
>> >
>> > > <mys...@gm...>
>> >
>> > > wrote:
>> >
>> > >
>> >
>> > >
>> >
>> > > Ok thank you for the patches. I tried to compile
>> > after
>> >
>> > > applying the 4 patches :
>> >
>> > > 1- win32
>> >
>> > > 2- midiclock
>> >
>> > > 3- mouseinteraction
>> >
>> > > 4- mutegroups + keybindings
>> >
>> > >
>> >
>> > > Unfortunately I got an error :
>> >
>> > >
>> >
>> > > .....
>> >
>> > > nclude -I/usr/include/uuid -I/usr/include/libxml2
>> >
>> > > -I/usr/include/alsa   -Wall -g -O2 -MT mainwid.o -MD
>> > -MP
>> >
>> > > -MF .deps/mainwid.Tpo -c -o mainwid.o mainwid.cpp
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > perform.h: In member function ‘void
>> >
>> > > mainwid::draw_sequence_on_pixmap(int)’:
>> >
>> > > perform.h:136: erreur: ‘bool
>> >
>> > > perform::m_show_ui_sequence_key’ is private
>> >
>> > > mainwid.cpp:214: erreur: à l'intérieur du
>> > contexte
>> >
>> > > make[2]: *** [mainwid.o] Erreur 1
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > make[2]: quittant le répertoire «
>> >
>> > > /home/mysthr/Logiciels/Musique/seq24-rev48/src »
>> >
>> > > make[1]: *** [all] Erreur 2
>> >
>> > > make[1]: quittant le répertoire «
>> >
>> > > /home/mysthr/Logiciels/Musique/seq24-rev48/src »
>> >
>> > > make: *** [all-recursive] Erreur 1
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > Any idea ?
>> >
>> > > Thanks
>> >
>> > >
>> >
>> > > Mysth-R
>> >
>> > >
>> >
>> > > ps : I am on linux ^^
>> >
>> > >
>> >
>> > >
>> >
>> > > 2009/5/18 Kevin Meinert <ke...@su...>
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > I'd be happy to check the stuff in myself, I have
>> > had
>> >
>> > > many years experience with revision control, cvs,
>> > svn,
>> >
>> > > perforce, alienbrain, sourcesafe...  Bazaar seems
>> > like svn
>> >
>> > > (at least it has tortoise bzr on windows, which is
>> > like
>> >
>> > > tortoise svn). So hopefully I could manage it... :)
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > Maybe someone can do a code review, and if good, can
>> > grant
>> >
>> > > me temporary check in access...  (i'll have a
>> > few
>> >
>> > > questions for you first of course, regarding where the
>> > new
>> >
>> > > win32 project files should go)...   We can always
>> > back it
>> >
>> > > out if something goes wrong.
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > It would be nice for someone to verify it works under
>> >
>> > > linux, as I have developed on win32 only...
>> >
>> > >
>> >
>> > >
>> >
>> > > Mysth-R, the order of patches should be as follows.
>> >
>> > > see here:  http://www.subatomicglue.com/seq24/
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > and get rev48 from bazaar, then apply patch 1, then 2,
>> > then
>> >
>> > > 3, then finally patch 4...  in that order.    You
>> >
>> > > _might_ have to edit the .patch file so that the
>> > directory
>> >
>> > > names match.  I don't know.  I would try the
>> > patch
>> >
>> > > first as is, and if it doesn't work go from
>> > there.
>> >
>> > > Feel free to ask for help.   I believe Frank's
>> > had
>> >
>> > > success applying the patches as well.
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > Alternately, I have posted the complete source code,
>> > so
>> >
>> > > maybe you can download that, overwrite your existing
>> > source,
>> >
>> > > and compile it there...
>> >
>> > >
>> http://www.subatomicglue.com/seq24/seq24-0.9.0-win32-beta-4-subatomic-src+bin.tgz
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > This is rev48 from bazaar, + my changes...
>> >
>> > >
>> >
>> > > ---
>> >
>> > > kevin meinert | http://www.subatomicglue.com
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > On Mon, May
>> >
>> > > 18, 2009 at 1:19 PM, Mysth-R <mys...@gm...>
>> >
>> > > wrote:
>> >
>> > >
>> >
>> > >
>> >
>> > > Hi,
>> >
>> > > Kevin, recently made very impressive improvements,
>> >
>> > > submitting severals patch. Thank you sooooo much kevin
>> > for
>> >
>> > > your work.
>> >
>> > > But I did not have time to apply the patch (since the
>> > first
>> >
>> > > you've posted). So now I am a bit lost : wich
>> > patch to
>> >
>> > > apply first, in wich order ?
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > So is it possible for the developpers to update the
>> > svn
>> >
>> > > version applying all kevin's patchs ?
>> >
>> > > I would be very good for everybody !
>> >
>> > >
>> >
>> > > Or perhaps, just give some privilege access to kevin
>> > ?
>> >
>> > > Thanks
>> >
>> > > cheers,
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > Mysth-R
>> >
>> > >
>> >
>> > >
>> >
>> > > --
>> >
>> > > *
>> >
>> > >
>> >
>> ***************************************************************************************
>> >
>> > > *  {^_^} Mysth-R {^_^}
>> >
>> > > *  <= Aide Auditive =>
>> >
>> > > *
>> >
>> > > * http://myspace.com/mysthr
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > * http://myspace.com/aideauditive
>> >
>> > > * http://mysthr.free.fr/Joomla
>> >
>> > >  => Site dédié à l'audio sous
>> >
>> > > Fedora/PlanetCCRMA.
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > *
>> >
>> > >
>> >
>> ***************************************************************************************
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> ------------------------------------------------------------------------------
>> >
>> > >
>> >
>> > > Crystal Reports - New Free Runtime and 30 Day Trial
>> >
>> > >
>> >
>> > > Check out the new simplified licensing option that
>> > enables
>> >
>> > >
>> >
>> > > unlimited royalty-free distribution of the report
>> > engine
>> >
>> > >
>> >
>> > > for externally facing server and web deployment.
>> >
>> > >
>> >
>> > > http://p.sf.net/sfu/businessobjects
>> >
>> > > _______________________________________________
>> >
>> > >
>> >
>> > > seq24-users mailing list
>> >
>> > >
>> >
>> > > seq...@li...
>> >
>> > >
>> >
>> > > https://lists.sourceforge.net/lists/listinfo/seq24-users
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > --
>> >
>> > > *
>> >
>> > >
>> >
>> ***************************************************************************************
>> >
>> > > *  {^_^} Mysth-R {^_^}
>> >
>> > > *  <= Aide Auditive =>
>> >
>> > >
>> >
>> > >
>> >
>> > > *
>> >
>> > > * http://myspace.com/mysthr
>> >
>> > >
>> >
>> > > * http://myspace.com/aideauditive
>> >
>> > > * http://mysthr.free.fr/Joomla
>> >
>> > >  => Site dédié à l'audio sous
>> >
>> > > Fedora/PlanetCCRMA.
>> >
>> > >
>> >
>> > >
>> >
>> > > *
>> >
>> > >
>> >
>> ***************************************************************************************
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > >
>> >
>> > > -----La pièce jointe associée suit-----
>> >
>> > >
>> >
>> > >
>> >
>> ------------------------------------------------------------------------------
>> >
>> > > Crystal Reports - New Free Runtime and 30 Day Trial
>> >
>> > > Check out the new simplified licensing option that
>> > enables
>> >
>> > >
>> >
>> > > unlimited royalty-free distribution of the report
>> > engine
>> >
>> > > for externally facing server and web deployment.
>> >
>> > > http://p.sf.net/sfu/businessobjects
>> >
>> > > -----La pièce jointe associée suit-----
>> >
>> > >
>> >
>> > > _______________________________________________
>> >
>> > > seq24-users mailing list
>> >
>> > > seq...@li...
>> >
>> > > https://lists.sourceforge.net/lists/listinfo/seq24-users
>> >
>> > >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>>
>>
>>
>>
>