Re: [seq24-users] WIN32 patch for seq24 (patch against the latest (rev 48) code from bazaar)

[Kevin M. <ke...@su...>]

Hi Guido


> I just went through this file and some questions occur. As I
> understand on Win32 there is no ALSA and LASH support, so this patch
> deals partly with this topics.


correct


> Further the MIDI implementation (portmidi)
> and time measuring is different, that are issues number three and four.

yes.


>
> What about JACK, supported or not?


I had thought Jack was not supported on windows, but looking at their site,
it looks like maybe there is something for win:
http://jackaudio.org/download

"JACK is system for handling real-time, low latency audio (and MIDI). It
runs on GNU/Linux, Solaris, FreeBSD, OS X and Windows (and can be ported to
other POSIX-conformant platforms)."

I had never heard of Jack used under WIN32 before and thought it a purely
linux thing, but looks like i'm mistaken...   IMHO as far as typical windows
users are concerned, I think if it wasn't there it wouldn't be missed.  And,
Rob had it compiled out in his version, not sure why, possibly Jack Win32
didn't exist at the time? (or maybe it doesn't work well, I don't know, just
speculating here)...

If someone on windows wants to compile with Jack they can probably use the
JACK_SUPPORT #define?   Let me know if you want me to try to get it
working.  Though really, I don't see why that couldn't come as a later
patch... (hopefully just enable the #define for JACK_SUPPORT... once it's
verified...).


What about <pthread.h>, do you need
> it for Windows or not?


Yes, there is pthread on win32, I compile with it.   see config_win32.h,
PTHREAD_SUPPORT is #defined as 1...


unfortunately the win32 patch I've submitted comes straight from Rob's code,
so I don't know all the rationale for these things to give perfect answers.
:-)    but I will try...


There are praeprocessor defines to differentiate between Win and the Linux
> system. They are based on a
>
>  #define WIN32_SUPPORT 1


>
> in the winconfig.h. For my understanding this define is not necessary
> because you can simply use
>
>  #ifdef __WIN32__
>  #endif
>

> in the source code without inventing a WIN32_SUPPORT variable. Can you
> please try to remove the
>
>  #define WIN32_SUPPORT 1
>
> line in your (win32) config.h and substitute all WIN32_SUPPORT variables by
> __WIN32__ in the source code, and try to compile?
>

good idea.   looks like it works here too.
patch files are now updated to reflect the __WIN32__ change.


The patch contains also larger amounts of code changes concerning
> background drawing of the sequencer roll. Are these changes basically
> necessary for Win support or part of an other feature/improvement?
>

These too come from Rob.  And when I did not put them in, performance in
windows with seq24 was awful.   Hopefully with this new drawing code it also
helps performance under linux?   It will be good to check that especially
(if you could?  as I don't have access to linux with a GUI running)...
The code did seem more efficient (i.e. didn't draw as much needlessly)...


BTW, I have already added the new some MIDI control values (event.h)
> to the bzr repository.
>

cool.



keep the ideas coming, I'll get on it... :)
thanks!



>
> Guido
>
> --
> http://www.bayernline.de/~gscholz/ <http://www.bayernline.de/%7Egscholz/>
> http://www.lug-burghausen.org/
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFKFH0Wk6cKJms5yBsRAh0NAJ9gto3yVMuQIbgNeFU4meZyginwMACfVv8Y
> zd4wbTKujT5Q4t8kYflQAn0=
> =zBJe
> -----END PGP SIGNATURE-----
>
>
> ------------------------------------------------------------------------------
> Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
> is a gathering of tech-side developers & brand creativity professionals.
> Meet
> the minds behind Google Creative Lab, Visual Complexity, Processing, &
> iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian
> Group, R/GA, & Big Spaceship. http://www.creativitycat.com
> _______________________________________________
> seq24-users mailing list
> seq...@li...
> https://lists.sourceforge.net/lists/listinfo/seq24-users
>
>