Re: [seq24-users] WIN32 patch for seq24 (patch against the latest (rev 48) code from bazaar)

[Guido S. <gui...@ba...>]

Am Tue, 14. Apr 2009 um 23:29:30 -0500 schrieb Kevin Meinert:

>    Hello Everyone,

Hi Kevin,

sorry for being late, but at this season I more like sitting on my
mountainbike (and recording openstreetmap tracks) than sitting in
front of my computer ;-).

>    WIN32 patch for seq24 (patch against the latest (rev 48) code from bazaar)
>        http://www.subatomicglue.com/seq24/rev48-add-win32.patch

I just went through this file and some questions occur. As I
understand on Win32 there is no ALSA and LASH support, so this patch
deals partly with this topics. Further the MIDI implementation (portmidi)
and time measuring is different, that are issues number three and four.
What about JACK, supported or not? What about <pthread.h>, do you need
it for Windows or not?

There are praeprocessor defines to differentiate between Win and the Linux
system. They are based on a

 #define WIN32_SUPPORT 1

in the winconfig.h. For my understanding this define is not necessary
because you can simply use

  #ifdef __WIN32__
  #endif

in the source code without inventing a WIN32_SUPPORT variable. Can you
please try to remove the

  #define WIN32_SUPPORT 1

line in your (win32) config.h and substitute all WIN32_SUPPORT variables by
__WIN32__ in the source code, and try to compile?


The patch contains also larger amounts of code changes concerning
background drawing of the sequencer roll. Are these changes basically
necessary for Win support or part of an other feature/improvement?


BTW, I have already added the new some MIDI control values (event.h)
to the bzr repository.

Guido

-- 
http://www.bayernline.de/~gscholz/
http://www.lug-burghausen.org/