Re: [seq24-users] : apply patch to the svn version

[Kevin M. <ke...@su...>]

for the time being, move that code to public (or put public: keyword before
it)  to get past the error.   I will take a look tonight.   this reminds me
of something I fixed already, so possibly I grabbed a slightly older diff by
mistake...   I will check it out.

what I think is probably wrong...
There should be a member in class perform that accesses that variable
(search for the variable in perform.h) and users of that variable should use
that accessor method rather than access the private data variable
directly.   unless it's the options class, in which case, options should be
a friend of that class (add a friend class options; to the bottom of perform
class)...

anyway, i'll follow up tonight...
---
kevin meinert | http://www.subatomicglue.com


On Tue, May 19, 2009 at 4:17 PM, Mysth-R <mys...@gm...> wrote:

> Ok thank you for the patches. I tried to compile after applying the 4
> patches :
> 1- win32
> 2- midiclock
> 3- mouseinteraction
> 4- mutegroups + keybindings
>
> Unfortunately I got an error :
>
> .....
> nclude -I/usr/include/uuid -I/usr/include/libxml2 -I/usr/include/alsa
> -Wall -g -O2 -MT mainwid.o -MD -MP -MF .deps/mainwid.Tpo -c -o mainwid.o
> mainwid.cpp
> perform.h: In member function ‘void mainwid::draw_sequence_on_pixmap(int)’:
> perform.h:136: erreur: ‘bool perform::m_show_ui_sequence_key’ is private
> mainwid.cpp:214: erreur: à l'intérieur du contexte
> make[2]: *** [mainwid.o] Erreur 1
> make[2]: quittant le répertoire «
> /home/mysthr/Logiciels/Musique/seq24-rev48/src »
> make[1]: *** [all] Erreur 2
> make[1]: quittant le répertoire «
> /home/mysthr/Logiciels/Musique/seq24-rev48/src »
> make: *** [all-recursive] Erreur 1
>
> Any idea ?
> Thanks
>
> Mysth-R
>
> ps : I am on linux ^^
>
>
> 2009/5/18 Kevin Meinert <ke...@su...>
>
>
>> I'd be happy to check the stuff in myself, I have had many years
>> experience with revision control, cvs, svn, perforce, alienbrain,
>> sourcesafe...  Bazaar seems like svn (at least it has tortoise bzr on
>> windows, which is like tortoise svn). So hopefully I could manage it... :)
>>
>> Maybe someone can do a code review, and if good, can grant me temporary
>> check in access...  (i'll have a few questions for you first of course,
>> regarding where the new win32 project files should go)...   We can always
>> back it out if something goes wrong.
>>
>> It would be nice for someone to verify it works under linux, as I have
>> developed on win32 only...
>>
>>
>> Mysth-R, the order of patches should be as follows.
>> see here:  http://www.subatomicglue.com/seq24/
>> and get rev48 from bazaar, then apply patch 1, then 2, then 3, then
>> finally patch 4...  in that order.    You _might_ have to edit the .patch
>> file so that the directory names match.  I don't know.  I would try the
>> patch first as is, and if it doesn't work go from there.  Feel free to ask
>> for help.   I believe Frank's had success applying the patches as well.
>>
>> Alternately, I have posted the complete source code, so maybe you can
>> download that, overwrite your existing source, and compile it there...
>>
>> http://www.subatomicglue.com/seq24/seq24-0.9.0-win32-beta-4-subatomic-src+bin.tgz
>> This is rev48 from bazaar, + my changes...
>>
>> ---
>> kevin meinert | http://www.subatomicglue.com
>>
>>
>> On Mon, May 18, 2009 at 1:19 PM, Mysth-R <mys...@gm...> wrote:
>>
>>> Hi,
>>> Kevin, recently made very impressive improvements, submitting severals
>>> patch. Thank you sooooo much kevin for your work.
>>> But I did not have time to apply the patch (since the first you've
>>> posted). So now I am a bit lost : wich patch to apply first, in wich order ?
>>> So is it possible for the developpers to update the svn version applying
>>> all kevin's patchs ?
>>> I would be very good for everybody !
>>>
>>> Or perhaps, just give some privilege access to kevin ?
>>> Thanks
>>> cheers,
>>>
>>> Mysth-R
>>>
>>> --
>>> *
>>> ***************************************************************************************
>>> *  {^_^} Mysth-R {^_^}
>>> *  <= Aide Auditive =>
>>> *
>>> * http://myspace.com/mysthr
>>> * http://myspace.com/aideauditive
>>> * http://mysthr.free.fr/Joomla  => Site dédié à l'audio sous
>>> Fedora/PlanetCCRMA.
>>> *
>>> ***************************************************************************************
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Crystal Reports - New Free Runtime and 30 Day Trial
>>> Check out the new simplified licensing option that enables
>>> unlimited royalty-free distribution of the report engine
>>> for externally facing server and web deployment.
>>> http://p.sf.net/sfu/businessobjects
>>> _______________________________________________
>>> seq24-users mailing list
>>> seq...@li...
>>> https://lists.sourceforge.net/lists/listinfo/seq24-users
>>>
>>>
>>
>
>
> --
> *
> ***************************************************************************************
> *  {^_^} Mysth-R {^_^}
> *  <= Aide Auditive =>
> *
> * http://myspace.com/mysthr
> * http://myspace.com/aideauditive
> * http://mysthr.free.fr/Joomla  => Site dédié à l'audio sous
> Fedora/PlanetCCRMA.
> *
> ***************************************************************************************
>